Bug 1193 - com.jogamp.opengl.util.glsl.ShaderCode doesn't support compute shaders
Summary: com.jogamp.opengl.util.glsl.ShaderCode doesn't support compute shaders
Status: RESOLVED FIXED
Alias: None
Product: Jogl
Classification: JogAmp
Component: opengl (show other bugs)
Version: 2.3.2
Hardware: All all
: --- enhancement
Assignee: Julien Gouesse
URL:
Depends on:
Blocks:
 
Reported: 2015-08-12 10:48 CEST by Julien Gouesse
Modified: 2015-09-27 03:15 CEST (History)
2 users (show)

See Also:
Type: FEATURE
SCM Refs:
4a1a777088cfd20875d2a99a71028e37e2c9fc92 8f56b4a0631fd4d8668573ff3baa704e22d8ed85 39661fb1d16149df7eabe818a25f44dac537c8a3
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 2 Sven Gothel 2015-08-18 03:56:22 CEST 
commit 4a1a777088cfd20875d2a99a71028e37e2c9fc92
    Adds the compute shaders into the list of supported shaders for ShaderCode

commit 8f56b4a0631fd4d8668573ff3baa704e22d8ed85
    Updates the documentation of the class ShaderCode concerning 
    the compute shaders
Comment 3 Sven Gothel 2015-08-18 03:58:51 CEST 
@Julien: It would be great if you could add a simple unit test 
using a compute shader (if this feature is available -> runtime query),
then we could demonstrate and test this feature.
In such case, simply add the SCM Ref here and add a new comment,
I will pull (email).
Comment 4 Julien Gouesse 2015-08-18 10:22:31 CEST 
Don't forget this tiny thing:
https://github.com/sgothel/jogl/commit/8f56b4a0631fd4d8668573ff3baa704e22d8ed85#diff-f52165b55f3aa3d21d51ef2b26ccf377R382

I can port this example of compute shader:
http://wili.cc/blog/opengl-cs.html
Comment 5 Sven Gothel 2015-08-18 11:27:43 CEST 
56f03908e476a4630d36282592e12bf20e589fa8
  ShaderCode: Add SUFFIX_COMPUTE_SOURCE/SUFFIX_COMPUTE_BINARY; 
  Add @since 2.3.2 tag
Comment 6 Sven Gothel 2015-08-18 11:28:25 CEST 
(In reply to comment #4)
> Don't forget this tiny thing:
> https://github.com/sgothel/jogl/commit/
> 8f56b4a0631fd4d8668573ff3baa704e22d8ed85#diff-
> f52165b55f3aa3d21d51ef2b26ccf377R382

commit 56f03908e476a4630d36282592e12bf20e589fa8
completes it .. right?

> 
> I can port this example of compute shader:
> http://wili.cc/blog/opengl-cs.html

that would be great!
Comment 7 Julien Gouesse 2015-08-18 11:48:52 CEST 
(In reply to comment #6)
> (In reply to comment #4)
> > Don't forget this tiny thing:
> > https://github.com/sgothel/jogl/commit/
> > 8f56b4a0631fd4d8668573ff3baa704e22d8ed85#diff-
> > f52165b55f3aa3d21d51ef2b26ccf377R382
> 
> commit 56f03908e476a4630d36282592e12bf20e589fa8
> completes it .. right?
> 
Rather this one??
https://github.com/sgothel/jogl/commit/39661fb1d16149df7eabe818a25f44dac537c8a3

> > 
> > I can port this example of compute shader:
> > http://wili.cc/blog/opengl-cs.html
> 
> that would be great!

I'll look for a simple unit test to extend.
Comment 8 Sven Gothel 2015-08-18 12:25:11 CEST 
(In reply to comment #7)
> Rather this one??
> https://github.com/sgothel/jogl/commit/
> 39661fb1d16149df7eabe818a25f44dac537c8a3

commit 39661fb1d16149df7eabe818a25f44dac537c8a3 yes,
sorry copy/paste error.