Bug 1208 - NEWT: Window: Consider avoiding operations if not supported, see getSupportedStateMask()
Summary: NEWT: Window: Consider avoiding operations if not supported, see getSupported...
Status: RESOLVED FIXED
Alias: None
Product: Newt
Classification: JogAmp
Component: core (show other bugs)
Version: 2.3.2
Hardware: All all
: --- enhancement
Assignee: Sven Gothel
URL:
Depends on: 1188
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-30 06:56 CEST by Sven Gothel
Modified: 2015-09-27 01:27 CEST (History)
0 users

See Also:
Type: ---
SCM Refs:
cc00d9b6c5a5c6b71ba14311fc6b17ce932d9a1e
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Gothel 2015-08-30 06:56:11 CEST 
As is, NEWT WindowImpl performs requested operation
regardless whether the native implementation supports it.

Here, the Window's stateMask is also modified 
regardless of successful operation.
Hence stateMask reflect the 'attempted operation' 
instead of the real state.

'getSupportedStateMask()' provides knowledge about
supported operations, as introduced via Bug 1188.

We may refine operations, i.e. not performing
operations and allow stateMask to reflect the real state.
Comment 1 Sven Gothel 2015-08-31 08:47:45 CEST 
cc00d9b6c5a5c6b71ba14311fc6b17ce932d9a1e

   Bug 1208 - NEWT: Window: Consider avoiding operations if not supported, see getSupportedStateMask()
    
    - Skip operation if not supported
    
    - Fix skip operation if isFullscreen() && !isNativeValid():
        We have to store the state w/o action,
        so the state can be picked up at native creation.