Attachment 345 Details for Bug 555 – New patch for MacOSXCGLContext.java that skips waitUntilNSOpenGLLayerIsReady() when v-sync is disabled

[patch] New patch for MacOSXCGLContext.java that skips waitUntilNSOpenGLLayerIsReady() when v-sync is disabled

MacOSXCGLContext.patch (text/plain), 1.76 KB, created by ac on 2012-03-18 23:37:09 CET

(hide)

Description:

Filename:

MIME Type:

Creator: ac

Created: 2012-03-18 23:37:09 CET

Size: 1.76 KB

patch

obsolete

>*** MacOSXCGLContext.java.repo	2012-03-15 15:23:08.000000000 -0400
>--- MacOSXCGLContext.java	2012-03-18 10:23:03.000000000 -0400
>***************
>*** 396,401 ****
>--- 396,402 ----
>    class NSOpenGLImpl implements GLBackendImpl {
>      long nsOpenGLLayer = 0;
>      long nsOpenGLLayerPFmt = 0;
>+     int vsyncTimeout = 16;
>      
>      public boolean isNSContext() { return true; }
>  
>***************
>*** 555,567 ****
>          CGL.setNSOpenGLLayerSwapInterval(nsOpenGLLayer, interval);
>        }
>        CGL.setSwapInterval(contextHandle, interval);
>        return true;
>      }
>      
>      public boolean swapBuffers() {
>!       if(0 != nsOpenGLLayer) {
>          // sync w/ CALayer renderer - wait until next frame is required (v-sync)
>!         CGL.waitUntilNSOpenGLLayerIsReady(nsOpenGLLayer, 16); // timeout 16ms -> 60Hz
>        }
>        if(CGL.flushBuffer(contextHandle)) {
>            if(0 != nsOpenGLLayer) {
>--- 556,577 ----
>          CGL.setNSOpenGLLayerSwapInterval(nsOpenGLLayer, interval);
>        }
>        CGL.setSwapInterval(contextHandle, interval);
>+       if (interval == 0) {
>+         // v-sync is disabled, frames were drawn as quickly as possible without adding any
>+         // timeout delay.
>+         vsyncTimeout = 0;
>+       } else {
>+         // v-sync is enabled. Swaping interval of 1 means a 
>+         // timeout of 16ms -> 60Hz, 60fps
>+         vsyncTimeout = interval * 16;
>+       }      
>        return true;
>      }
>      
>      public boolean swapBuffers() {
>!       if(0 != nsOpenGLLayer && 0 < vsyncTimeout) {
>          // sync w/ CALayer renderer - wait until next frame is required (v-sync)
>!         CGL.waitUntilNSOpenGLLayerIsReady(nsOpenGLLayer, vsyncTimeout); 
>        }
>        if(CGL.flushBuffer(contextHandle)) {
>            if(0 != nsOpenGLLayer) {

Actions: View | Diff

Attachments on bug 555: 328 | 330 | 331 | 340 | 345