1054 2014-08-29 15:05:02 +0200 GLContext: makeCurrent() needs a null-check of [mutable] drawable; Review null checks and synchronization/locking. 2014-08-30 12:04:22 +0200 1 1 3 JogAmp Jogl core 2 All all RESOLVED FIXED --- major --- 1 sgothel sgothel askinner sgothel --- ad79bd072b600a3f2416cc6f0c61e2925000069d dfb9ed47ac6d8e85f6ae5fe166e7a6e28ca8ff83 11347ad39059836f3e2a4f1fc592dc1e3fab6a09 da16dfd39cc17687808308c386d64f6206027c00 --- oldest_to_newest 4130 0 sgothel 2014-08-29 15:05:02 +0200 4131 1 sgothel 2014-08-30 00:12:13 +0200 'drawable' field of GLContextImpl is mutable via setGLDrawable(..), which requires high-level locking as documented. The required high-level locking allows us to _not_ add special synchronization to this field (and drawableRead). A simple null-check in makeCurrent() shall be sufficient, plus ensuring mentioned high-level locking is applied. 4132 2 sgothel 2014-08-30 00:22:14 +0200 11347ad39059836f3e2a4f1fc592dc1e3fab6a09 GLContextImpl 'drawable' and 'drawableRead' synchronization: - commit ad79bd072b600a3f2416cc6f0c61e2925000069d check of null drawable is sufficient - Add GLAutoDrawable upstream-lock locking to: - AWT GLCanvas setupPrint/releasePrint - AWT GLJPanel (was missing) Misc: - validate shared-context native-surface locking, throw exception if not successful - pixelDataEvaluated does not need to be synchronized, since it's being called while context is current, locking - GLDrawableHelper.recreateGLDrawable(..): Remove redundant glFinish() call