<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://jogamp.org/bugzilla/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.2"
          urlbase="https://jogamp.org/bugzilla/"
          
          maintainer="sgothel@jausoft.com"
>

    <bug>
          <bug_id>1193</bug_id>
          
          <creation_ts>2015-08-12 10:48:43 +0200</creation_ts>
          <short_desc>com.jogamp.opengl.util.glsl.ShaderCode doesn&apos;t support compute shaders</short_desc>
          <delta_ts>2015-09-27 03:15:03 +0200</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>JogAmp</classification>
          <product>Jogl</product>
          <component>opengl</component>
          <version>2.3.2</version>
          <rep_platform>All</rep_platform>
          <op_sys>all</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>---</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Julien Gouesse">gouessej</reporter>
          <assigned_to name="Julien Gouesse">gouessej</assigned_to>
          <cc>gouessej</cc>
    
    <cc>sgothel</cc>
          
          <cf_type>FEATURE</cf_type>
          <cf_scm_refs>4a1a777088cfd20875d2a99a71028e37e2c9fc92
8f56b4a0631fd4d8668573ff3baa704e22d8ed85
39661fb1d16149df7eabe818a25f44dac537c8a3</cf_scm_refs>
          <cf_workaround>---</cf_workaround>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>4921</commentid>
    <comment_count>0</comment_count>
    <who name="Julien Gouesse">gouessej</who>
    <bug_when>2015-08-12 10:48:43 +0200</bug_when>
    <thetext>ShaderCode supports the vertex shaders, the fragment shaders, the geometry shaders, the tesselation shaders (control + evaluation) but not the compute shaders:
https://github.com/sgothel/jogl/blob/master/src/jogl/classes/com/jogamp/opengl/util/glsl/ShaderCode.java#L141
https://github.com/sgothel/jogl/blob/master/src/jogl/classes/com/jogamp/opengl/util/glsl/ShaderCode.java#L171
https://github.com/sgothel/jogl/blob/master/src/jogl/classes/com/jogamp/opengl/util/glsl/ShaderCode.java#L771
https://github.com/sgothel/jogl/blob/master/src/jogl/classes/com/jogamp/opengl/util/glsl/ShaderCode.java#L1287
https://github.com/sgothel/jogl/blob/master/src/jogl/classes/com/jogamp/opengl/util/glsl/ShaderCode.java#L1311

GL3ES3.GL_COMPUTE_SHADER should be used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4939</commentid>
    <comment_count>1</comment_count>
    <who name="Julien Gouesse">gouessej</who>
    <bug_when>2015-08-13 21:03:13 +0200</bug_when>
    <thetext>https://github.com/gouessej/jogl/commit/4a1a777088cfd20875d2a99a71028e37e2c9fc92
https://github.com/gouessej/jogl/commit/8f56b4a0631fd4d8668573ff3baa704e22d8ed85</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4955</commentid>
    <comment_count>2</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2015-08-18 03:56:22 +0200</bug_when>
    <thetext>commit 4a1a777088cfd20875d2a99a71028e37e2c9fc92
    Adds the compute shaders into the list of supported shaders for ShaderCode

commit 8f56b4a0631fd4d8668573ff3baa704e22d8ed85
    Updates the documentation of the class ShaderCode concerning 
    the compute shaders</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4956</commentid>
    <comment_count>3</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2015-08-18 03:58:51 +0200</bug_when>
    <thetext>@Julien: It would be great if you could add a simple unit test 
using a compute shader (if this feature is available -&gt; runtime query),
then we could demonstrate and test this feature.
In such case, simply add the SCM Ref here and add a new comment,
I will pull (email).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4959</commentid>
    <comment_count>4</comment_count>
    <who name="Julien Gouesse">gouessej</who>
    <bug_when>2015-08-18 10:22:31 +0200</bug_when>
    <thetext>Don&apos;t forget this tiny thing:
https://github.com/sgothel/jogl/commit/8f56b4a0631fd4d8668573ff3baa704e22d8ed85#diff-f52165b55f3aa3d21d51ef2b26ccf377R382

I can port this example of compute shader:
http://wili.cc/blog/opengl-cs.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4963</commentid>
    <comment_count>5</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2015-08-18 11:27:43 +0200</bug_when>
    <thetext>56f03908e476a4630d36282592e12bf20e589fa8
  ShaderCode: Add SUFFIX_COMPUTE_SOURCE/SUFFIX_COMPUTE_BINARY; 
  Add @since 2.3.2 tag</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4964</commentid>
    <comment_count>6</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2015-08-18 11:28:25 +0200</bug_when>
    <thetext>(In reply to comment #4)
&gt; Don&apos;t forget this tiny thing:
&gt; https://github.com/sgothel/jogl/commit/
&gt; 8f56b4a0631fd4d8668573ff3baa704e22d8ed85#diff-
&gt; f52165b55f3aa3d21d51ef2b26ccf377R382

commit 56f03908e476a4630d36282592e12bf20e589fa8
completes it .. right?

&gt; 
&gt; I can port this example of compute shader:
&gt; http://wili.cc/blog/opengl-cs.html

that would be great!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4965</commentid>
    <comment_count>7</comment_count>
    <who name="Julien Gouesse">gouessej</who>
    <bug_when>2015-08-18 11:48:52 +0200</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #4)
&gt; &gt; Don&apos;t forget this tiny thing:
&gt; &gt; https://github.com/sgothel/jogl/commit/
&gt; &gt; 8f56b4a0631fd4d8668573ff3baa704e22d8ed85#diff-
&gt; &gt; f52165b55f3aa3d21d51ef2b26ccf377R382
&gt; 
&gt; commit 56f03908e476a4630d36282592e12bf20e589fa8
&gt; completes it .. right?
&gt; 
Rather this one??
https://github.com/sgothel/jogl/commit/39661fb1d16149df7eabe818a25f44dac537c8a3

&gt; &gt; 
&gt; &gt; I can port this example of compute shader:
&gt; &gt; http://wili.cc/blog/opengl-cs.html
&gt; 
&gt; that would be great!

I&apos;ll look for a simple unit test to extend.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4968</commentid>
    <comment_count>8</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2015-08-18 12:25:11 +0200</bug_when>
    <thetext>(In reply to comment #7)
&gt; Rather this one??
&gt; https://github.com/sgothel/jogl/commit/
&gt; 39661fb1d16149df7eabe818a25f44dac537c8a3

commit 39661fb1d16149df7eabe818a25f44dac537c8a3 yes,
sorry copy/paste error.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>