1283 2016-01-12 11:01:11 +0100 Jogl can't find #include shader relative files 2019-03-26 23:20:59 +0100 1 1 3 JogAmp Jogl opengl 2.4.0 pc_x86_64 windows RESOLVED FIXED P4 normal --- 1 elect86 elect86 gouessej sgothel DEFECT jogl 7e4c32ba709346ce4009d50e506ebc4c079d7c1e jogl 2319a207873cf88da4ce0dadc5e7a2e5479d4254 --- oldest_to_newest 5511 0 elect86 2016-01-12 11:01:11 +0100 Minimal sample to replicate the bug https://github.com/elect86/joglBug 5523 1 elect86 2016-01-29 13:53:43 +0100 I just found out that this work #include draw-image-space-rendering.glsl May we modify it in order to accept also the quotes? #include "draw-image-space-rendering.glsl" 5533 2 gouessej 2016-02-16 20:03:18 +0100 (In reply to Giuseppe Barbieri from comment #1) > I just found out that this work > > #include draw-image-space-rendering.glsl > > May we modify it in order to accept also the quotes? > > #include "draw-image-space-rendering.glsl" Are you sure that JOGL is to blame for that? 5535 3 elect86 2016-02-16 21:18:04 +0100 yeah, I created a pull request https://github.com/sgothel/jogl/pull/95 5537 4 elect86 2016-02-16 21:21:19 +0100 btw, I just saw there are other pull requests lying there 5538 5 gouessej 2016-02-17 00:19:58 +0100 (In reply to Giuseppe Barbieri from comment #4) > btw, I just saw there are other pull requests lying there Some of them have been accepted but not through Github. 5539 6 elect86 2016-02-17 08:26:12 +0100 through what then? 5560 7 gouessej 2016-02-29 17:38:30 +0100 (In reply to Giuseppe Barbieri from comment #6) > through what then? Sven can receive git patches by email without using Github. In my humble opinion, we should remove the quotes only when they are at the start and at the end of the string. 5561 8 elect86 2016-02-29 17:43:49 +0100 I agree, shall I modify the pull then? 5563 9 gouessej 2016-02-29 20:36:14 +0100 (In reply to Giuseppe Barbieri from comment #8) > I agree, shall I modify the pull then? There is no hurry and you'll have to make a pull request against my repository later when I'm ready anyway. 6044 10 gouessej 2017-06-06 10:55:06 +0200 I accepted Guiseppe's pull request but I have to edit a few things (braces, ...). 6101 11 sgothel 2019-03-26 23:20:59 +0100 Bug 1283: Remove shader include filename quotes if exists at start and end only