154 2005-04-02 09:44:45 +0200 Patches for build problems 2015-09-27 03:09:34 +0200 0 0 3 JogAmp Jogl core 1 All all VERIFIED FIXED P1 normal --- 1 sgothel sgothel DEFECT --- oldest_to_newest 170 0 sgothel 2010-03-24 07:47:44 +0100 ---- Reported by gtgtgtgtgtgtgt 2005-04-02 09:44:45 ---- These two minor fixes address the problems discussed here: http://www.javagaming.org/cgi-bin/JGNetForums/YaBB.cgi?board=jogl;action=display;num=1108328385 The first part handles an invalid lvalue complaint from the stricter GCC 4 preview, and the second part fixes a bug in gluegen preventing jogl from building reliably. Index: src/net/java/games/gluegen/CMethodBindingEmitter.java =================================================================== RCS file: /cvs/jogl/src/net/java/games/gluegen/CMethodBindingEmitter.java,v retrieving revision 1.7 diff -u -r1.7 CMethodBindingEmitter.java --- src/net/java/games/gluegen/CMethodBindingEmitter.java 4 Oct 2004 22:55:38 -0000 1.7 +++ src/net/java/games/gluegen/CMethodBindingEmitter.java 2 Apr 2005 09:02:11 -0000 @@ -609,7 +609,7 @@ writer.print(" "); emitGetStringUTFChars(writer, "(jstring) _tmpObj", - "(const char*)"+convName+"_copy[_copyIndex]"); + convName+"_copy[_copyIndex]"); } else if (isNIOBufferClass(subArrayElementJavaType)) { Index: src/net/java/games/gluegen/cgram/types/CompoundType.java =================================================================== RCS file: /cvs/jogl/src/net/java/games/gluegen/cgram/types/CompoundType.java,v retrieving revision 1.2 diff -u -r1.2 CompoundType.java --- src/net/java/games/gluegen/cgram/types/CompoundType.java 14 Jul 2003 05:34:51 -0000 1.2 +++ src/net/java/games/gluegen/cgram/types/CompoundType.java 2 Apr 2005 09:02:11 -0000 @@ -88,6 +88,8 @@ if (arg == null || (!(arg instanceof CompoundType))) { return false; } + if (arg.hashCode() != hashCode()) + return false; CompoundType t = (CompoundType) arg; return (super.equals(arg) && kind == t.kind && ---- Additional Comments From kbr 2005-04-04 11:35:16 ---- Submitted patches had a couple of problems. First, the removal of the (incorrect) cast to const char* in the CMethodBindingEmitter caused build warnings on other platforms. Fixed these by making the const declarations correct for the conversion case of String[] -> char**. Second, addition of comparison of hashCodes in CompoundType.equals() seemed like too much of a hack. Fixed this by correcting potential problems in equals() and hashCode() methods; not sure whether this will solve the submitter's original problem, though. The applied diffs have been added as an attachment. ---- Additional Comments From kbr 2005-04-04 11:36:18 ---- Created an attachment diffs applied to tree --- Bug imported by sgothel@jausoft.com 2010-03-24 07:47 EDT --- This bug was previously known as _bug_ 154 at https://jogl.dev.java.net/bugs/show_bug.cgi?id=154 Imported an attachment (id=47) The original submitter of attachment 47 is unknown. Reassigning to the person who moved it here: sgothel@jausoft.com. 47 2005-04-04 11:36:00 +0200 2005-04-04 11:36:00 +0200 diffs applied to tree diffs.txt text/plain 3727 sgothel SW5kZXg6IHNyYy9uZXQvamF2YS9nYW1lcy9nbHVlZ2VuL0NNZXRob2RCaW5kaW5nRW1pdHRlci5q YXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvam9nbC9zcmMvbmV0L2phdmEvZ2FtZXMvZ2x1 ZWdlbi9DTWV0aG9kQmluZGluZ0VtaXR0ZXIuamF2YSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43 CmRpZmYgLWMgLXIxLjcgQ01ldGhvZEJpbmRpbmdFbWl0dGVyLmphdmEKKioqIHNyYy9uZXQvamF2 YS9nYW1lcy9nbHVlZ2VuL0NNZXRob2RCaW5kaW5nRW1pdHRlci5qYXZhCTQgT2N0IDIwMDQgMjI6 NTU6MzggLTAwMDAJMS43Ci0tLSBzcmMvbmV0L2phdmEvZ2FtZXMvZ2x1ZWdlbi9DTWV0aG9kQmlu ZGluZ0VtaXR0ZXIuamF2YQk0IEFwciAyMDA1IDE4OjMzOjI2IC0wMDAwCioqKioqKioqKioqKioq KgoqKiogNjA5LDYxNSAqKioqCiAgICAgICAgICAgICAgd3JpdGVyLnByaW50KCIgICIpOwogICAg ICAgICAgICAgIGVtaXRHZXRTdHJpbmdVVEZDaGFycyh3cml0ZXIsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICIoanN0cmluZykgX3RtcE9iaiIsCiEgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICIoY29uc3QgY2hhciopIitjb252TmFtZSsiX2NvcHlbX2NvcHlJ bmRleF0iKTsKICAgICAgICAgICAgfQogICAgICAgICAgICBlbHNlIGlmIChpc05JT0J1ZmZlckNs YXNzKHN1YkFycmF5RWxlbWVudEphdmFUeXBlKSkKICAgICAgICAgICAgewotLS0gNjA5LDYxNSAt LS0tCiAgICAgICAgICAgICAgd3JpdGVyLnByaW50KCIgICIpOwogICAgICAgICAgICAgIGVtaXRH ZXRTdHJpbmdVVEZDaGFycyh3cml0ZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICIoanN0cmluZykgX3RtcE9iaiIsCiEgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnZOYW1lKyJfY29weVtfY29weUluZGV4XSIpOwogICAgICAgICAgICB9CiAgICAgICAg ICAgIGVsc2UgaWYgKGlzTklPQnVmZmVyQ2xhc3Moc3ViQXJyYXlFbGVtZW50SmF2YVR5cGUpKQog ICAgICAgICAgICB7CioqKioqKioqKioqKioqKgoqKiogNzgxLDc4NyAqKioqCiAgICAgICAgICAg IH0KICAKICAgICAgICAgICAgLy8gZnJlZSB0aGUgbWFpbiBhcnJheQohICAgICAgICAgICB3cml0 ZXIucHJpbnQoIiAgICBmcmVlKCIpOwogICAgICAgICAgICB3cml0ZXIucHJpbnQoY29udk5hbWUr Il9jb3B5Iik7CiAgICAgICAgICAgIHdyaXRlci5wcmludGxuKCIpOyIpOwogICAgICAgICAgfSAv LyBlbmQgb2YgY2xlYW5pbmcgdXAgY29waWVkIGRhdGEKLS0tIDc4MSw3ODcgLS0tLQogICAgICAg ICAgICB9CiAgCiAgICAgICAgICAgIC8vIGZyZWUgdGhlIG1haW4gYXJyYXkKISAgICAgICAgICAg d3JpdGVyLnByaW50KCIgICAgZnJlZSgodm9pZCopICIpOwogICAgICAgICAgICB3cml0ZXIucHJp bnQoY29udk5hbWUrIl9jb3B5Iik7CiAgICAgICAgICAgIHdyaXRlci5wcmludGxuKCIpOyIpOwog ICAgICAgICAgfSAvLyBlbmQgb2YgY2xlYW5pbmcgdXAgY29waWVkIGRhdGEKKioqKioqKioqKioq KioqCioqKiAxMjUxLDEyNTcgKioqKgogICAgICAgIENsYXNzIGVsZW1lbnRUeXBlID0gamF2YVR5 cGUuZ2V0SmF2YUNsYXNzKCkuZ2V0Q29tcG9uZW50VHlwZSgpOwogICAgICAgIGlmIChqYXZhVHlw ZS5pc0FycmF5KCkgJiYKICAgICAgICAgICAgamF2YVR5cGUuZ2V0SmF2YUNsYXNzKCkuZ2V0Q29t cG9uZW50VHlwZSgpID09IGphdmEubGFuZy5TdHJpbmcuY2xhc3MpIHsKISAgICAgICAgIHdyaXRl ci5wcmludCgiICBjaGFyICoqIik7CiAgICAgICAgfSBlbHNlIHsKICAgICAgICAgIHdyaXRlci5w cmludChwdHJUeXBlU3RyaW5nKTsKICAgICAgICB9Ci0tLSAxMjUxLDEyNTcgLS0tLQogICAgICAg IENsYXNzIGVsZW1lbnRUeXBlID0gamF2YVR5cGUuZ2V0SmF2YUNsYXNzKCkuZ2V0Q29tcG9uZW50 VHlwZSgpOwogICAgICAgIGlmIChqYXZhVHlwZS5pc0FycmF5KCkgJiYKICAgICAgICAgICAgamF2 YVR5cGUuZ2V0SmF2YUNsYXNzKCkuZ2V0Q29tcG9uZW50VHlwZSgpID09IGphdmEubGFuZy5TdHJp bmcuY2xhc3MpIHsKISAgICAgICAgIHdyaXRlci5wcmludCgiICBjb25zdCBjaGFyICoqIik7CiAg ICAgICAgfSBlbHNlIHsKICAgICAgICAgIHdyaXRlci5wcmludChwdHJUeXBlU3RyaW5nKTsKICAg ICAgICB9CkluZGV4OiBzcmMvbmV0L2phdmEvZ2FtZXMvZ2x1ZWdlbi9jZ3JhbS90eXBlcy9Db21w b3VuZFR5cGUuamF2YQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL2pvZ2wvc3JjL25ldC9qYXZh L2dhbWVzL2dsdWVnZW4vY2dyYW0vdHlwZXMvQ29tcG91bmRUeXBlLmphdmEsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMgpkaWZmIC1jIC1yMS4yIENvbXBvdW5kVHlwZS5qYXZhCioqKiBzcmMvbmV0 L2phdmEvZ2FtZXMvZ2x1ZWdlbi9jZ3JhbS90eXBlcy9Db21wb3VuZFR5cGUuamF2YQkxNCBKdWwg MjAwMyAwNTozNDo1MSAtMDAwMAkxLjIKLS0tIHNyYy9uZXQvamF2YS9nYW1lcy9nbHVlZ2VuL2Nn cmFtL3R5cGVzL0NvbXBvdW5kVHlwZS5qYXZhCTQgQXByIDIwMDUgMTg6MzM6MjYgLTAwMDAKKioq KioqKioqKioqKioqCioqKiA3Niw4MiAqKioqCiAgICAgIH0gZWxzZSBpZiAoZ2V0TmFtZSgpICE9 IG51bGwpIHsKICAgICAgICBoYXNoY29kZSA9IGdldE5hbWUoKS5oYXNoQ29kZSgpOwogICAgICB9 IGVsc2UgewohICAgICAgIGhhc2hjb2RlID0gU3lzdGVtLmlkZW50aXR5SGFzaENvZGUodGhpcyk7 CiAgICAgIH0KICAKICAgICAgY29tcHV0ZWRIYXNoY29kZSA9IHRydWU7Ci0tLSA3Niw4MiAtLS0t CiAgICAgIH0gZWxzZSBpZiAoZ2V0TmFtZSgpICE9IG51bGwpIHsKICAgICAgICBoYXNoY29kZSA9 IGdldE5hbWUoKS5oYXNoQ29kZSgpOwogICAgICB9IGVsc2UgewohICAgICAgIGhhc2hjb2RlID0g MDsKICAgICAgfQogIAogICAgICBjb21wdXRlZEhhc2hjb2RlID0gdHJ1ZTsKKioqKioqKioqKioq KioqCioqKiA5MCw5NyAqKioqCiAgICAgIH0KICAgICAgQ29tcG91bmRUeXBlIHQgPSAoQ29tcG91 bmRUeXBlKSBhcmc7CiAgICAgIHJldHVybiAoc3VwZXIuZXF1YWxzKGFyZykgJiYKISAgICAgICAg ICAgICAgICAgICAgICAgIGtpbmQgPT0gdC5raW5kICYmCiEgICAgICAgICAgICAgICAgICAgICAg ICBsaXN0c0VxdWFsKGZpZWxkcywgdC5maWVsZHMpKTsKICAgIH0KICAKICAgIC8qKiBSZXR1cm5z IHRoZSBzdHJ1Y3QgbmFtZSBvZiB0aGlzIENvbXBvdW5kVHlwZSwgaS5lLiB0aGUgImZvbyIgaW4K LS0tIDkwLDk4IC0tLS0KICAgICAgfQogICAgICBDb21wb3VuZFR5cGUgdCA9IChDb21wb3VuZFR5 cGUpIGFyZzsKICAgICAgcmV0dXJuIChzdXBlci5lcXVhbHMoYXJnKSAmJgohICAgICAgICAgICAg IChzdHJ1Y3ROYW1lID09IHQuc3RydWN0TmFtZSB8fCAoc3RydWN0TmFtZSAhPSBudWxsICYmIHN0 cnVjdE5hbWUuZXF1YWxzKHQuc3RydWN0TmFtZSkpKSAmJgohICAgICAgICAgICAgIGtpbmQgPT0g dC5raW5kICYmCiEgICAgICAgICAgICAgbGlzdHNFcXVhbChmaWVsZHMsIHQuZmllbGRzKSk7CiAg ICB9CiAgCiAgICAvKiogUmV0dXJucyB0aGUgc3RydWN0IG5hbWUgb2YgdGhpcyBDb21wb3VuZFR5 cGUsIGkuZS4gdGhlICJmb28iIGluCg==