458 2011-01-14 16:47:38 +0100 clCreateProgramWithSource does not block on MacOS 2011-01-22 03:04:08 +0100 1 1 3 JogAmp Jocl opencl 1 All macosx VERIFIED FIXED http://jogamp.762907.n3.nabble.com/jocl-CLProgram-create-line-74-tp2250272p2250272.html P2 blocker --- 1 bienator bienator rwlentz DEFECT --- oldest_to_newest 770 0 217 bienator 2011-01-14 16:47:38 +0100 Created attachment 217 junit test we suspect that the Apple implementation of OpenCL does not use a copy of the provided sources but uses the provided source string directly. The current JNI binding code assumes that the function (http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/clCreateProgramWithSource.html) blocks until the code is fully uploaded (same as in GLSL). Result is a race condition with often not compileable programs. All other CL implementations block and use a copy (tested on amd, intel, nv). further investigation needed. There are multiple ways to fix this issue... 771 1 bienator 2011-01-14 16:52:46 +0100 mailing list discussion: http://jogamp.762907.n3.nabble.com/jocl-CLProgram-create-line-74-tp2250272p2250272.html 772 2 bienator 2011-01-14 17:31:14 +0100 Rick Lentz / mailing list: I tested on another Mac just to ensure that it was not a single case regarding APPLE. Here is the console output /results (Failed): OS: Mac OS X ARCH: x86_64 VM: Java HotSpot(TM) 64-Bit Server VM lib path: /Users/hinerm/Documents/workspace/OpenCLIterative3DDeconvolution/lib:/Users/hinerm/Documents/workspace/OpenCLIterative3DDeconvolution/lib/APPLE CLContext [id: 4296115824, platform: Apple, profile: FULL_PROFILE, devices: 2] OpenCL 1.0 (Aug 22 2010 18:08:16) src: __kernel vo ... compilation failed 784 3 bienator 2011-01-22 01:38:22 +0100 bug fixed in build 246: http://jogamp.org/chuck/view/fwd/job/jocl/label=macosx-10_6-x86_64/246/ commit: https://github.com/mbien/jocl/commit/6ca42ce154439b8c2f7f76ce4300ae08678f223a could you take a look and verify that its working for you also? (if not please reopen the bug) please use the high level api with CLProgram.create(...) since the test is also broken :) 785 4 bienator 2011-01-22 03:03:31 +0100 The content of attachment 217 has been deleted by Michael Bien <bienator@arcor.de> without providing any reason. The token used to delete this attachment was generated at 2011-01-22 03:03:19 CET. 786 5 221 bienator 2011-01-22 03:04:08 +0100 Created attachment 221 new test case 217 2011-01-14 16:47:38 +0100 2011-01-14 16:47:38 +0100 junit test ProgramTest.java text/plain 0 bienator 221 2011-01-22 03:04:08 +0100 2011-01-22 03:04:08 +0100 new test case Bug458.java text/x-java 6159 bienator LyoKICogQ29weXJpZ2h0IDIwMTAgSm9nQW1wIENvbW11bml0eS4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICoKICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0IG1vZGlmaWNhdGlvbiwgYXJlCiAqIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUgbWV0OgogKiAKICogICAgMS4gUmVk aXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmln aHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YKICogICAgICAgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyLgogKiAKICogICAgMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBm b3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3QK ICogICAgICAgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRo ZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMKICogICAgICAgcHJvdmlkZWQg d2l0aCB0aGUgZGlzdHJpYnV0aW9uLgogKiAKICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBC WSBKb2dBbXAgQ29tbXVuaXR5IGBgQVMgSVMnJyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRAog KiBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQg V0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5ECiAqIEZJVE5FU1MgRk9SIEEgUEFSVElD VUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBKb2dBbXAgQ29t bXVuaXR5IE9SCiAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCiAqIENPTlNFUVVFTlRJQUwg REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNV QlNUSVRVVEUgR09PRFMgT1IKICogU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9G SVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTgogKiBB TlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJ TElUWSwgT1IgVE9SVCAoSU5DTFVESU5HCiAqIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT SU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRgog KiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICogCiAqIFRoZSB2 aWV3cyBhbmQgY29uY2x1c2lvbnMgY29udGFpbmVkIGluIHRoZSBzb2Z0d2FyZSBhbmQgZG9jdW1l bnRhdGlvbiBhcmUgdGhvc2Ugb2YgdGhlCiAqIGF1dGhvcnMgYW5kIHNob3VsZCBub3QgYmUgaW50 ZXJwcmV0ZWQgYXMgcmVwcmVzZW50aW5nIG9mZmljaWFsIHBvbGljaWVzLCBlaXRoZXIgZXhwcmVz c2VkCiAqIG9yIGltcGxpZWQsIG9mIEpvZ0FtcCBDb21tdW5pdHkuCiAqLwoKcGFja2FnZSBjb20u am9nYW1wLm9wZW5jbDsKCmltcG9ydCBjb20uam9nYW1wLm9wZW5jbC51dGlsLkNMVXRpbDsKaW1w b3J0IGphdmEubmlvLkJ5dGVCdWZmZXI7CmltcG9ydCBjb20uam9nYW1wLmNvbW1vbi5uaW8uQnVm ZmVyczsKaW1wb3J0IGNvbS5qb2dhbXAuY29tbW9uLm5pby5Qb2ludGVyQnVmZmVyOwppbXBvcnQg amF2YS5uaW8uSW50QnVmZmVyOwppbXBvcnQgb3JnLmp1bml0LkJlZm9yZUNsYXNzOwppbXBvcnQg b3JnLmp1bml0LlRlc3Q7CgppbXBvcnQgc3RhdGljIGphdmEubGFuZy5TeXN0ZW0uKjsKCnB1Ymxp YyBjbGFzcyBCdWc0NTggewoKICAgIEBCZWZvcmVDbGFzcwogICAgcHVibGljIHN0YXRpYyB2b2lk IHNldFVwQ2xhc3MoKSB0aHJvd3MgRXhjZXB0aW9uIHsKICAgICAgICBvdXQucHJpbnRsbigiT1M6 ICIgKyBTeXN0ZW0uZ2V0UHJvcGVydHkoIm9zLm5hbWUiKSk7CiAgICAgICAgb3V0LnByaW50bG4o IkFSQ0g6ICIgKyBTeXN0ZW0uZ2V0UHJvcGVydHkoIm9zLmFyY2giKSk7CiAgICAgICAgb3V0LnBy aW50bG4oIlZNOiAiICsgU3lzdGVtLmdldFByb3BlcnR5KCJqYXZhLnZtLm5hbWUiKSk7CiAgICAg ICAgb3V0LnByaW50bG4oImxpYiBwYXRoOiAiICsgU3lzdGVtLmdldFByb3BlcnR5KCJqYXZhLmxp YnJhcnkucGF0aCIpKTsKICAgIH0KICAgIAogICAgcHJpdmF0ZSBmaW5hbCBzdGF0aWMgU3RyaW5n IHByb2dyYW1Tb3VyY2UgPSIiCi8vICAgICAgICAgICAgICsgIiAjcHJhZ21hIE9QRU5DTCBFWFRF TlNJT04gY2xfa2hyX2ZwNjQ6IGVuYWJsZSAgIFxuIgogICAgICAgICAgICAgKyIgICBfX2tlcm5l bCB2b2lkIHNvYmVsKCBfX2dsb2JhbCBmbG9hdCogaW5wdXQsIF9fZ2xvYmFsIGZsb2F0KiBvdXRw dXQsIGludCB3aWR0aCwgIGludCBoZWlnaHQgKSB7ICAgICBcbiIKICAgICAgICAgICAgICsiICAg ICAgIGludCB4ID0gZ2V0X2dsb2JhbF9pZCgwKTsgICBcbiIKICAgICAgICAgICAgICsiICAgICAg IGludCB5ID0gZ2V0X2dsb2JhbF9pZCgxKTsgICBcbiIKICAgICAgICAgICAgICsiICAgICAgIGlu dCBvZmZzZXQgPSB5ICogd2lkdGggKyB4OyAgIFxuIgogICAgICAgICAgICAgKyIgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIK ICAgICAgICAgICAgICsiICAgICAgICAgZmxvYXQgcDAsIHAxLCBwMiwgcDMsIHA1LCBwNiwgcDcs IHA4ID0gMDsgICAgICAgICAgICBcbiIKICAgICAgICAgICAgICsiICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXG4iCiAgICAgICAg ICAgICArIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFxuIgogICAgICAgICAgICAgKyIgICAgICAgICAgICAgIGlmKCB4IDwgMSB8 fCB5IDwgMSB8fCB4ID4gd2lkdGggLSAyIHx8IHkgPiBoZWlnaHQgLSAyICkgICBcbiIKICAgICAg ICAgICAgICsiICAgICAgICAgICAgICB7ICAgXG4iCiAgICAgICAgICAgICArIiAgICAgICAgICAg ICAgICAgb3V0cHV0W29mZnNldF0gPSAwOyAgIFxuIgogICAgICAgICAgICAgKyIgICAgICAgICAg ICAgIH0gICBcbiIKICAgICAgICAgICAgICsiICAgICAgICAgICAgICBlbHNlICAgXG4iCiAgICAg ICAgICAgICArIiAgICAgICAgICAgICAgeyAgIFxuIgogICAgICAgICAgICAgKyIgICAgICAgICAg ICAgICAgICBwMCA9IGlucHV0W29mZnNldCAtIHdpZHRoIC0gMV0gOyAgIFxuIgogICAgICAgICAg ICAgKyIgICAgICAgICAgICAgICAgICBwMSA9IGlucHV0W29mZnNldCAtIHdpZHRoXSA7ICAgXG4i CiAgICAgICAgICAgICArIiAgICAgICAgICAgICAgICAgIHAyID0gaW5wdXRbb2Zmc2V0IC0gd2lk dGggKyAxXSA7ICAgXG4iCiAgICAgICAgICAgICArIiAgICAgICAgICAgICAgICAgIHAzID0gaW5w dXRbb2Zmc2V0IC0gMV0gOyAgIFxuIgogICAgICAgICAgICAgKyIgICAgICAgICAgICAgICAgICBw NSA9IGlucHV0W29mZnNldCArIDFdIDsgICBcbiIKICAgICAgICAgICAgICsiICAgICAgICAgICAg ICAgICAgcDYgPSBpbnB1dFtvZmZzZXQgKyB3aWR0aCAtIDFdIDsgICBcbiIgCiAgICAgICAgICAg ICArIiAgICAgICAgICAgICAgICAgIHA3ID0gaW5wdXRbb2Zmc2V0ICsgd2lkdGhdIDsgICBcbiIK ICAgICAgICAgICAgICsiICAgICAgICAgICAgICAgICAgcDggPSBpbnB1dFtvZmZzZXQgKyB3aWR0 aCArIDFdIDsgICBcbiIgCiAgICAgICAgICAgICArIiAgIFxuIgogICAgICAgICAgICAgKyIgICAg ICAgICAgICAgICAgICBmbG9hdCBzdW0xID0gcDAgKyAyKnAxICsgcDIgLSBwNiAtIDIqcDcgLSBw ODsgIC8vR1kgICBcbiIKICAgICAgICAgICAgICsiICAgICAgICAgICAgICAgICAgZmxvYXQgc3Vt MiA9IHAwICsgMipwMyArIHA2IC0gcDIgLSAyKnA1IC0gcDg7ICAvL0dYICAgXG4iCiAgICAgICAg ICAgICArIiAgIFxuIgogICAgICAgICAgICAgKyIgICAgICAgICAgICAgICAgICBvdXRwdXRbb2Zm c2V0XSA9IHNxcnQoICBzdW0xKnN1bTEgKyBzdW0yKnN1bTIgKTsgICBcbiIKICAgICAgICAgICAg ICsiICAgICAgICAgICAgICB9ICAgXG4iCiAgICAgICAgICAgICArIiAgICAgIH0gICI7IAoKICAg IEBUZXN0CiAgICBwdWJsaWMgdm9pZCBidWlsZFByb2dyYW1UZXN0KCkgewogICAgICAgIAogICAg ICAgIENMQ29udGV4dCBjb250ZXh0ID0gQ0xDb250ZXh0LmNyZWF0ZSgpOwogICAgICAgIAogICAg ICAgIHRyeSB7CiAgICAgICAgICAgIFN5c3RlbS5vdXQucHJpbnRsbihjb250ZXh0KTsKICAgICAg ICAgICAgU3lzdGVtLm91dC5wcmludGxuKGNvbnRleHQuZ2V0UGxhdGZvcm0oKS5nZXRWZXJzaW9u KCkpOwoKICAgICAgICAgICAgbG9uZyBjb250ZXh0SUQgPSBjb250ZXh0LklEOwogICAgICAgICAg ICBDTCBjbCA9IENMUGxhdGZvcm0uZ2V0TG93TGV2ZWxDTEludGVyZmFjZSgpOwoKICAgICAgICAg ICAgUG9pbnRlckJ1ZmZlciBidWZmZXIgPSAoUG9pbnRlckJ1ZmZlcikgUG9pbnRlckJ1ZmZlci5h bGxvY2F0ZURpcmVjdCgxKS5wdXQocHJvZ3JhbVNvdXJjZS5sZW5ndGgoKSkucmV3aW5kKCk7CiAg ICAgICAgICAgIFN0cmluZ1tdIHNyY0FycmF5ID0gbmV3IFN0cmluZ1tde3Byb2dyYW1Tb3VyY2V9 OwoKICAgICAgICAgICAgSW50QnVmZmVyIHVwbG9hZFN0YXR1cyA9IEJ1ZmZlcnMubmV3RGlyZWN0 SW50QnVmZmVyKDEpOwogICAgICAgICAgICBmaW5hbCBsb25nIHByb2dyYW1JRCA9IGNsLmNsQ3Jl YXRlUHJvZ3JhbVdpdGhTb3VyY2UoY29udGV4dElELCAxLCBzcmNBcnJheSwgYnVmZmVyLCB1cGxv YWRTdGF0dXMpOwogICAgICAgICAgICBjaGVja0Vycm9yKCJvbiBjbENyZWF0ZVByb2dyYW1XaXRo U291cmNlIiwgdXBsb2FkU3RhdHVzLmdldCgwKSk7CgogICAgICAgICAgICAvLyBCdWlsZCB0aGUg cHJvZ3JhbQogICAgICAgICAgICBpbnQgYnVpbGRTdGF0dXMgPSBjbC5jbEJ1aWxkUHJvZ3JhbShw cm9ncmFtSUQsIDAsIG51bGwsIG51bGwsIG51bGwpOwoKICAgICAgICAgICAgU3lzdGVtLm91dC5w cmludGxuKCJidWZmZXJjb250ZW50OiAiK2J1ZmZlci5nZXQoMCkpOwogICAgICAgICAgICAKICAg ICAgICAgICAgU3lzdGVtLm91dC5wcmludGxuKCJzcmM6ICIgKyBnZXRQcm9ncmFtSW5mb1N0cmlu ZyhjbCwgcHJvZ3JhbUlELCBDTC5DTF9QUk9HUkFNX1NPVVJDRSkpOwogICAgICAgICAgICAKICAg ICAgICAgICAgY2hlY2tFcnJvcigib24gY2xCdWlsZFByb2dyYW0iLCBidWlsZFN0YXR1cyk7CiAg ICAgICAgICAgIFN5c3RlbS5vdXQucHJpbnRsbigiLT4gc3VjY2VzcyIpOwogICAgICAgIH0gZmlu YWxseSB7CiAgICAgICAgICAgIGNvbnRleHQucmVsZWFzZSgpOwogICAgICAgIH0KICAgIH0KICAg IAogICAgcHJpdmF0ZSBTdHJpbmcgZ2V0UHJvZ3JhbUluZm9TdHJpbmcoQ0wgY2wsIGxvbmcgcHJv Z3JhbSwgaW50IGZsYWcpIHsKCiAgICAgICAgUG9pbnRlckJ1ZmZlciBzaXplID0gUG9pbnRlckJ1 ZmZlci5hbGxvY2F0ZURpcmVjdCgxKTsKCiAgICAgICAgaW50IHJldCA9IGNsLmNsR2V0UHJvZ3Jh bUluZm8ocHJvZ3JhbSwgZmxhZywgMCwgbnVsbCwgc2l6ZSk7CiAgICAgICAgY2hlY2tFcnJvcigi b24gY2xHZXRQcm9ncmFtSW5mbyIsIHJldCk7CgogICAgICAgIEJ5dGVCdWZmZXIgYnVmZmVyID0g QnVmZmVycy5uZXdEaXJlY3RCeXRlQnVmZmVyKChpbnQpc2l6ZS5nZXQoMCkpOwoKICAgICAgICBy ZXQgPSBjbC5jbEdldFByb2dyYW1JbmZvKHByb2dyYW0sIGZsYWcsIGJ1ZmZlci5jYXBhY2l0eSgp LCBidWZmZXIsIG51bGwpOwogICAgICAgIGNoZWNrRXJyb3IoIm9uIGNsR2V0UHJvZ3JhbUluZm8i LCByZXQpOwoKICAgICAgICByZXR1cm4gQ0xVdGlsLmNsU3RyaW5nMkphdmFTdHJpbmcoYnVmZmVy LCAoaW50KXNpemUuZ2V0KDApKTsKICAgIH0KCiAgICBwcml2YXRlIHZvaWQgY2hlY2tFcnJvcihT dHJpbmcgbXNnLCBpbnQgcmV0KSB7CiAgICAgICAgaWYocmV0ICE9IENMLkNMX1NVQ0NFU1MpCiAg ICAgICAgICAgIHRocm93IENMRXhjZXB0aW9uLm5ld0V4Y2VwdGlvbihyZXQsIG1zZyk7CiAgICB9 Cn0K