579 2012-05-06 10:20:15 +0200 CLGLTexture2d.createFromGLTexture2d always fails due to passing id and not error to checkForError 2013-10-12 23:39:51 +0200 1 1 3 JogAmp Jocl opengl 1 All all RESOLVED FIXED P4 normal --- 1 kjolhede bienator danielbalog86 gouessej sgothel --- ec14381e0bd681c354de1a002894a628f8bf69e5 --- oldest_to_newest 1567 0 kjolhede 2012-05-06 10:20:15 +0200 High level OO wrapper bug: In CLGLTexture2d.createFromGLTexture2d the checkForError call gets passed the texture id instead of the error flag from the clCreateFromGLTexture2D call: checkForError((int)id, "can not share memory with texture #"+texture+"."); Instead it should be: checkForError(result[0], "can not share memory with texture #"+texture+"."); This is a bug in the high level abstraction layer, but the low level JNI bindings work fine for sharing gl-cl textures, so you can use that instead in the meantime, but it would be great to get this high level stuff working also :). It means CLGLTexture2d.createFromGLTexture2d will always fail when it actually succeeds ;). 1691 1 danielbalog86 2012-07-03 12:49:02 +0200 I would like to confirm this bug. It popped up as I was testing CLGLContext. The workaround (when you don't have the JOCL src) involves copy-pasting the method and initializing everything with reflection, which is tedious. I'll post a patch. 1693 2 360 danielbalog86 2012-07-03 13:45:36 +0200 Created attachment 360 fix for CLGLTexture2d patch This patch fixes the bug. It is an extremely easy fix. I see no reason to not apply the patch. Note that the bug is probably due to a typo. Check the clCreateFromGLTexture2D documentation if you don't believe me ;) http://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/clCreateFromGLTexture2D.html 2371 3 gouessej 2013-03-27 14:57:04 +0100 We should really look at the suggested patch. 3104 4 sgothel 2013-10-12 23:39:05 +0200 Use result value in checkForError(..) for CLGLTexture2d.createFromGL* CLGLTexture3d.createFromGL* CLGLImage2d.createFromGL* CLGLBuffer.createFromGL* instead of returned 'id' Thank you Johan & Daniel ! Using your original patch, I went through the other CLGL[Texture*|Image2d|Buffer] classes and ensured all are handled the same. @Daniel: This has nothing to do w/ trust, but I had little resources left and I am only the 'interim' maintainer - we are looking for a new one. Again: Thank you! 3105 5 sgothel 2013-10-12 23:39:51 +0200 To all: If the patch is erroneous .. pls reopen and send a git pull request / patch. No unit test! Thank you! 360 2012-07-03 13:45:36 +0200 2012-07-03 13:45:36 +0200 fix for CLGLTexture2d patch CLGLTexture2d_bug_fix.patch text/plain 4853 danielbalog86 SW5kZXg6IC4uLy4uL0FwcGxpY2F0aW9ucy9qb2NsL3NyYy9jb20vam9nYW1wL29wZW5jbC9nbC9D TEdMVGV4dHVyZTJkLmphdmEKSURFQSBhZGRpdGlvbmFsIGluZm86ClN1YnN5c3RlbTogY29tLmlu dGVsbGlqLm9wZW5hcGkuZGlmZi5pbXBsLnBhdGNoLkNoYXJzZXRFUAo8Kz5VVEYtOApTdWJzeXN0 ZW06IGNvbS5pbnRlbGxpai5vcGVuYXBpLmRpZmYuaW1wbC5wYXRjaC5CYXNlUmV2aXNpb25UZXh0 UGF0Y2hFUAo8Kz4vKlxuICogQ29weXJpZ2h0IDIwMDkgLSAyMDEwIEpvZ0FtcCBDb21tdW5pdHku IEFsbCByaWdodHMgcmVzZXJ2ZWQuXG4gKlxuICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0IG1vZGlmaWNhdGlvbiwgYXJl XG4gKiBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJl IG1ldDpcbiAqIFxuICogICAgMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3Qg cmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2ZcbiAqICAgICAg IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci5cbiAqIFxuICogICAgMi4g UmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBj b3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3RcbiAqICAgICAgIG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIg bWF0ZXJpYWxzXG4gKiAgICAgICBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uXG4gKiBc biAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgSm9nQW1wIENvbW11bml0eSBgYEFTIElT JycgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRURcbiAqIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJ TElUWSBBTkRcbiAqIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJ TUVELiBJTiBOTyBFVkVOVCBTSEFMTCBKb2dBbXAgQ29tbXVuaXR5IE9SXG4gKiBDT05UUklCVVRP UlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lB TCwgRVhFTVBMQVJZLCBPUlxuICogQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUlxuICog U0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRF UlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTlxuICogQU5ZIFRIRU9SWSBPRiBMSUFCSUxJ VFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xV RElOR1xuICogTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQg T0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGXG4gKiBBRFZJU0VEIE9GIFRIRSBQ T1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS5cbiAqIFxuICogVGhlIHZpZXdzIGFuZCBjb25jbHVz aW9ucyBjb250YWluZWQgaW4gdGhlIHNvZnR3YXJlIGFuZCBkb2N1bWVudGF0aW9uIGFyZSB0aG9z ZSBvZiB0aGVcbiAqIGF1dGhvcnMgYW5kIHNob3VsZCBub3QgYmUgaW50ZXJwcmV0ZWQgYXMgcmVw cmVzZW50aW5nIG9mZmljaWFsIHBvbGljaWVzLCBlaXRoZXIgZXhwcmVzc2VkXG4gKiBvciBpbXBs aWVkLCBvZiBKb2dBbXAgQ29tbXVuaXR5LlxuICovXG5cbnBhY2thZ2UgY29tLmpvZ2FtcC5vcGVu Y2wuZ2w7XG5cbmltcG9ydCBjb20uam9nYW1wLm9wZW5jbC5sbGIuQ0w7XG5pbXBvcnQgY29tLmpv Z2FtcC5vcGVuY2wuQ0xDb250ZXh0O1xuaW1wb3J0IGNvbS5qb2dhbXAub3BlbmNsLkNMSW1hZ2VG b3JtYXQ7XG5pbXBvcnQgY29tLmpvZ2FtcC5vcGVuY2wubGxiLmltcGwuQ0xJbWFnZUZvcm1hdElt cGw7XG5pbXBvcnQgY29tLmpvZ2FtcC5vcGVuY2wubGxiLmdsLkNMR0w7XG5pbXBvcnQgamF2YS5u aW8uQnVmZmVyO1xuXG5pbXBvcnQgc3RhdGljIGNvbS5qb2dhbXAub3BlbmNsLkNMRXhjZXB0aW9u Lio7XG5pbXBvcnQgc3RhdGljIGNvbS5qb2dhbXAub3BlbmNsLmxsYi5DTC4qO1xuXG4vKipcbiAq IDJEIE9wZW5DTCBpbWFnZSByZXByZXNlbnRpbmcgYW4gMkQgT3BlbkdMIHRleHR1cmUuXG4gKiBA YXV0aG9yIE1pY2hhZWwgQmllblxuICovXG5wdWJsaWMgY2xhc3MgQ0xHTFRleHR1cmUyZDxCIGV4 dGVuZHMgQnVmZmVyPiBleHRlbmRzIENMR0xJbWFnZTJkPEI+IGltcGxlbWVudHMgQ0xHTFRleHR1 cmUge1xuXG4gICAgcHVibGljIGZpbmFsIGludCB0YXJnZXQ7XG4gICAgXG4gICAgcHVibGljIGZp bmFsIGludCBtaXBNYXBMZXZlbDtcblxuICAgIHB1YmxpYyBDTEdMVGV4dHVyZTJkKENMQ29udGV4 dCBjb250ZXh0LCBCIGRpcmVjdEJ1ZmZlciwgQ0xJbWFnZUZvcm1hdCBmb3JtYXQsIENMSW1hZ2VJ bmZvQWNjZXNzb3IgYWNjZXNzb3IsIGludCB0YXJnZXQsIGludCBtaXBMZXZlbCwgaW50IHdpZHRo LCBpbnQgaGVpZ2h0LCBsb25nIGlkLCBpbnQgZ2xpZCwgaW50IGZsYWdzKSB7XG4gICAgICAgIHN1 cGVyKGNvbnRleHQsIGRpcmVjdEJ1ZmZlciwgZm9ybWF0LCBhY2Nlc3Nvciwgd2lkdGgsIGhlaWdo dCwgaWQsIGdsaWQsIGZsYWdzKTtcbiAgICAgICAgdGhpcy50YXJnZXQgPSB0YXJnZXQ7XG4gICAg ICAgIHRoaXMubWlwTWFwTGV2ZWwgPSBtaXBMZXZlbDtcbiAgICB9XG5cbiAgICBzdGF0aWMgPEIg ZXh0ZW5kcyBCdWZmZXI+IENMR0xUZXh0dXJlMmQ8Qj4gY3JlYXRlRnJvbUdMVGV4dHVyZTJkKENM Q29udGV4dCBjb250ZXh0LCBCIGRpcmVjdEJ1ZmZlciwgaW50IHRhcmdldCwgaW50IHRleHR1cmUs IGludCBtaXBMZXZlbCwgaW50IGZsYWdzKSB7XG5cbiAgICAgICAgQ0xHTEJ1ZmZlci5jaGVja0J1 ZmZlcihkaXJlY3RCdWZmZXIsIGZsYWdzKTtcblxuICAgICAgICBDTCBjbCA9IGdldENMKGNvbnRl eHQpO1xuICAgICAgICBpbnRbXSByZXN1bHQgPSBuZXcgaW50WzFdO1xuICAgICAgICBDTEdMIGNs Z2xpID0gKENMR0wpY2w7XG5cbiAgICAgICAgbG9uZyBpZCA9IGNsZ2xpLmNsQ3JlYXRlRnJvbUdM VGV4dHVyZTJEKGNvbnRleHQuSUQsIGZsYWdzLCB0YXJnZXQsIG1pcExldmVsLCB0ZXh0dXJlLCBy ZXN1bHQsIDApO1xuICAgICAgICBjaGVja0ZvckVycm9yKChpbnQpaWQsIFwiY2FuIG5vdCBzaGFy ZSBtZW1vcnkgd2l0aCB0ZXh0dXJlICNcIit0ZXh0dXJlK1wiLlwiKTtcblxuICAgICAgICBDTElt YWdlSW5mb0FjY2Vzc29yIGFjY2Vzc29yID0gbmV3IENMSW1hZ2VJbmZvQWNjZXNzb3IoY2wsIGlk KTtcblxuICAgICAgICBDTEltYWdlRm9ybWF0IGZvcm1hdCA9IGNyZWF0ZVVuaW5pdGlhbGl6ZWRJ bWFnZUZvcm1hdCgpO1xuICAgICAgICBhY2Nlc3Nvci5nZXRJbmZvKENMX0lNQUdFX0ZPUk1BVCwg Q0xJbWFnZUZvcm1hdEltcGwuc2l6ZSgpLCBmb3JtYXQuZ2V0Rm9ybWF0SW1wbCgpLmdldEJ1ZmZl cigpLCBudWxsKTtcblxuICAgICAgICBpbnQgd2lkdGggPSAoaW50KWFjY2Vzc29yLmdldExvbmco Q0xfSU1BR0VfV0lEVEgpO1xuICAgICAgICBpbnQgaGVpZ2h0ID0gKGludClhY2Nlc3Nvci5nZXRM b25nKENMX0lNQUdFX0hFSUdIVCk7XG5cbiAgICAgICAgcmV0dXJuIG5ldyBDTEdMVGV4dHVyZTJk PEI+KGNvbnRleHQsIGRpcmVjdEJ1ZmZlciwgZm9ybWF0LCBhY2Nlc3NvciwgdGFyZ2V0LCBtaXBM ZXZlbCwgd2lkdGgsIGhlaWdodCwgaWQsIHRleHR1cmUsIGZsYWdzKTtcblxuICAgIH1cblxuICAg IEBPdmVycmlkZVxuICAgIHB1YmxpYyBpbnQgZ2V0VGV4dHVyZVRhcmdldCgpIHtcbiAgICAgICAg cmV0dXJuIHRhcmdldDtcbiAgICB9XG5cbiAgICBAT3ZlcnJpZGVcbiAgICBwdWJsaWMgaW50IGdl dE1pcE1hcExldmVsKCkge1xuICAgICAgICByZXR1cm4gbWlwTWFwTGV2ZWw7XG4gICAgfVxuXG4g ICAgQE92ZXJyaWRlXG4gICAgcHVibGljIEdMT2JqZWN0VHlwZSBnZXRHTE9iamVjdFR5cGUoKSB7 XG4gICAgICAgIHJldHVybiBHTE9iamVjdFR5cGUuR0xfT0JKRUNUX1RFWFRVUkUyRDtcbiAgICB9 XG5cblxufVxuCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIC4uLy4uL0FwcGxpY2F0aW9ucy9qb2NsL3NyYy9jb20v am9nYW1wL29wZW5jbC9nbC9DTEdMVGV4dHVyZTJkLmphdmEJKHJldmlzaW9uIDM2MzBkMDZiYzQ4 NThmZjgyZWE4Y2JlN2I2OTlmZGEyMTFjMGVjNDcpCisrKyAuLi8uLi9BcHBsaWNhdGlvbnMvam9j bC9zcmMvY29tL2pvZ2FtcC9vcGVuY2wvZ2wvQ0xHTFRleHR1cmUyZC5qYXZhCShyZXZpc2lvbiAp CkBAIC02Myw3ICs2Myw3IEBACiAgICAgICAgIENMR0wgY2xnbGkgPSAoQ0xHTCljbDsKIAogICAg ICAgICBsb25nIGlkID0gY2xnbGkuY2xDcmVhdGVGcm9tR0xUZXh0dXJlMkQoY29udGV4dC5JRCwg ZmxhZ3MsIHRhcmdldCwgbWlwTGV2ZWwsIHRleHR1cmUsIHJlc3VsdCwgMCk7Ci0gICAgICAgIGNo ZWNrRm9yRXJyb3IoKGludClpZCwgImNhbiBub3Qgc2hhcmUgbWVtb3J5IHdpdGggdGV4dHVyZSAj Iit0ZXh0dXJlKyIuIik7CisgICAgICAgIGNoZWNrRm9yRXJyb3IocmVzdWx0WzBdLCAiY2FuIG5v dCBzaGFyZSBtZW1vcnkgd2l0aCB0ZXh0dXJlICMiK3RleHR1cmUrIi4iKTsKIAogICAgICAgICBD TEltYWdlSW5mb0FjY2Vzc29yIGFjY2Vzc29yID0gbmV3IENMSW1hZ2VJbmZvQWNjZXNzb3IoY2ws IGlkKTsKIAo=