<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://jogamp.org/bugzilla/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.2"
          urlbase="https://jogamp.org/bugzilla/"
          
          maintainer="sgothel@jausoft.com"
>

    <bug>
          <bug_id>688</bug_id>
          
          <creation_ts>2013-02-11 10:34:54 +0100</creation_ts>
          <short_desc>Removal of NEWT KeyEvent.EVENT_KEY_TYPED and KeyListener.keyTyped(KeyEvent)</short_desc>
          <delta_ts>2013-06-17 10:12:07 +0200</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>JogAmp</classification>
          <product>Newt</product>
          <component>core</component>
          <version>1</version>
          <rep_platform>All</rep_platform>
          <op_sys>all</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>678</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sven Gothel">sgothel</reporter>
          <assigned_to name="Sven Gothel">sgothel</assigned_to>
          <cc>gouessej</cc>
    
    <cc>xerxes</cc>
          
          <cf_type>---</cf_type>
          <cf_scm_refs>jogl 85338858f5c58694fa88e77df1386d0556887944
jogl 8b33170ec6fd3f215976875cb66d746fa1b48f61
jogl bdfb74818aa224bd96a15f232f417e921e0d8f63</cf_scm_refs>
          <cf_workaround>---</cf_workaround>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2167</commentid>
    <comment_count>0</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2013-02-11 10:34:54 +0100</bug_when>
    <thetext>I reviewed the NEWT key press/release/type thingy again (windows, etc ..).
While solving the UTF-char problem (again), I see that the TYPED event is
redundant now, since we deliver the UTF-char for all events.

Hence I like to remova NEWT KeyEvent.EVENT_KEY_TYPED and
it&apos;s KeyListener.keyTyped(KeyEvent) listener.

This will reduce the event 1/3 for keyboard .. which is reasonable IMHO
considering the &apos;headaches&apos; of the change.

User code change: Simply trigger on RELEASE instead of TYPED.

Opinions ?

~Sven</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2199</commentid>
    <comment_count>1</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2013-02-19 08:07:00 +0100</bug_when>
    <thetext>http://jogamp.org/git/?p=jogl.git;a=commit;h=85338858f5c58694fa88e77df1386d0556887944

- prepared, marked deprecated .. etc see commit message
- code change also shows redundancy of TYPED event</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2234</commentid>
    <comment_count>2</comment_count>
    <who name="Xerxes Rånby">xerxes</who>
    <bug_when>2013-03-05 08:52:36 +0100</bug_when>
    <thetext>TODO: This bugs needs to be fixed for the Rasberry Pi LinuxEventDeviceTracker, that still use the depricated code, to make the generated events compatible with new client code such as the new JMonkeyEngine that already have been patched for this bug.
http://forum.jogamp.org/JOGL-2-0-OpenGL-OpenGL-ES-backend-for-LibGDX-tp4027689p4028486.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2235</commentid>
    <comment_count>3</comment_count>
    <who name="Xerxes Rånby">xerxes</who>
    <bug_when>2013-03-05 11:41:55 +0100</bug_when>
    <thetext>&gt; TODO: This bugs needs to be fixed for the Rasberry Pi
&gt; LinuxEventDeviceTracker, that still use the depricated code, to make the
&gt; generated events compatible with new client code such as the new
&gt; JMonkeyEngine that already have been patched for this bug.
&gt; http://forum.jogamp.org/JOGL-2-0-OpenGL-OpenGL-ES-backend-for-LibGDX-
&gt; tp4027689p4028486.html

Kudos to sgothel for already implementing the TODO in 85338858f5c58694fa88e77df1386d0556887944
http://jogamp.org/git/?p=jogl.git;a=blobdiff;f=src/newt/classes/jogamp/newt/driver/linux/LinuxEventDeviceTracker.java;h=2c0e6d3dd5163b80b21de9e5fac15f8d499245cc;hp=5efce2524a9ac343d2a9e2c7ac4bab826252a149;hb=85338858f5c58694fa88e77df1386d0556887944;hpb=a40ee817a3bd537b0de7018772b0835f995a1bed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2683</commentid>
    <comment_count>4</comment_count>
    <who name="Sven Gothel">sgothel</who>
    <bug_when>2013-06-17 10:12:07 +0200</bug_when>
    <thetext>gone .. done</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>