841 2013-09-24 19:38:16 +0200 GLJPanel "lagging" by one frame. 2014-08-30 20:04:13 +0200 1 1 3 JogAmp Jogl awt 2 All all RESOLVED WORKSFORME --- major --- 0 sgothel sgothel bkuker --- --- oldest_to_newest 2985 0 sgothel 2013-09-24 19:38:16 +0200 GLJPanel's offscreen FBO usage [w/o GLSL flip] seems to lag by one frame. 2987 1 505 bkuker 2013-09-25 00:35:02 +0200 Created attachment 505 A test program 2988 2 bkuker 2013-09-25 00:41:08 +0200 When you create a GLJPanel using multisampling and disable the GLSL flip code the image displayed on screen lags one frame behind the image rendered by the display() method. This means the very first frame displayed is garbage from video memory. This is only very noticeable in a non-animated situation when repaint() is called in response to user input. For example in my application a user can select a part of the model in a menu and that part is highlighted. The image on screen displays the previously selected part. Click on the Head and nothing happens, click on the Arm and the Head is highlighted, click on the Leg and the Arm is higlighted, etc. In the sample program the constructor is: public Bug841(boolean enableAA, boolean glsl)... These three work correctly new Bug841(true, true); new Bug841(false, true); new Bug841(false, false); // This one is the problem one. new Bug841(true, false); NOTE: Because GLSL is controlled via a system property you must only run ONE of these at a time, do NOT uncomment them all. 3135 3 sgothel 2013-10-19 03:02:35 +0200 Hi Bill, I tested you use case w/ latest git tip and I could not reproduce it. I verified that AA was enabled and GLSL not, see dump below. Since GLJPanel operates OS agnostic I assume my test on GNU/Linux w/ an NV card is representative. If you still experience this bug, please reopen and try to send me more detailed information (Wiki/FAQ/Bugreport). Maybe a better test .. as well. Thank you. ~Sven main: GLJPanel.addNotify() main: GLJPanel.reshape resize [ panel 0x0, reshape: 0x0] -> 390x270 AWT-EventQueue-0: GLJPanel.reshape resize [ panel 0x0, reshape: 390x270] -> 392x273 AWT-EventQueue-0: GLJPanel.createAndInitializeBackend: 0x0 -> 392x273 AWT-EventQueue-0: OffscreenBackend: initialize() AWT-EventQueue-0: OffscreenBackend.initialize: useGLSLFlip false [flip true, isFBO true, isGL2ES2 true, noglsl true, glslNonCompliant false, isGL2ES2 true] AWT-EventQueue-0: GLJPanel.handleReshape: 392x273 -> 392x273 AWT-EventQueue-0: GLJPanel.OffscreenBackend.handleReshape: 392x273 -> 392x273 AWT-EventQueue-0: GLJPanel.display: reshape(0,0 392x273) XXX GLCaps[glx vid 0x27, fbc 0x10d: rgba 8/8/8/8, opaque, accum-rgba 0/0/0/0, dp/st/ms 24/0/6, sample-ext default, dbl, mono , hw, GLProfile[GL2/GL2.hw], offscr[fbo]] AWT-EventQueue-0: GLJPanel.OffscreenBackend.postGL.0: pixelBufferProvider isSingletonBufferProvider true, 0x7312c7dd, SingleAWTGLPixelBufferProvider AWT-EventQueue-0: GLJPanel.OffscreenBackend.postGL.0: pixelBuffer 0x55ffb930, AWTGLPixelBuffer[PixelAttributes[comp 3, fmt 0x80e1, type 0x1401, bytesPerPixel 4], dim 392x273x1, pack true, disposed false, valid true, buffer[bytes 428064, elemSize 4, java.nio.HeapIntBuffer[pos=0 lim=107016 cap=107016]], allowRowStride true, image [392x273, BufferedImage@7d72a6c: type = 1 DirectColorModel: rmask=ff0000 gmask=ff00 bmask=ff amask=0 IntegerInterleavedRaster: width = 392 height = 273 #Bands = 3 xOff = 0 yOff = 0 dataOffset[0] 0]], alignment 1 AWT-EventQueue-0: GLJPanel.OffscreenBackend.postGL.0: flippedVertical true, glslTextureRaster false AWT-EventQueue-0: GLJPanel.OffscreenBackend.postGL.0: panelSize 392x273 AWT-EventQueue-0: GLJPanel.OffscreenBackend.postGL.0: alignedImage 392x273, pixelBuffer 392x273 3139 4 bkuker 2013-10-19 04:41:55 +0200 To be honest I have not managed to build JOGL from source, the build process seems like it is looking for some additional utilities to be installed to work. If this is fixed in git I'll let you know after the next release. BTW since the problem is using glReadPixels on an multi-sampled FBO this could be hardware dependent I think. 3140 5 bkuker 2013-10-19 04:46:32 +0200 Here are some links: http://stackoverflow.com/questions/765434/glreadpixels-from-fbo-fails-with-multisampling/819463#819463 http://www.khronos.org/message_boards/showthread.php/7637-How-to-read-Pixel-data-from-the-MultiSampled-framebuffer I realize they are just Q&A forums, but they are what led me to this conclusion. What would you suggest for a better test case? The code I provided shows one obviously different behavior out of four (At least on affected systems). 3142 6 sgothel 2013-10-19 05:23:06 +0200 (In reply to comment #5) > Here are some links: > > http://stackoverflow.com/questions/765434/glreadpixels-from-fbo-fails-with- > multisampling/819463#819463 > > http://www.khronos.org/message_boards/showthread.php/7637-How-to-read-Pixel- > data-from-the-MultiSampled-framebuffer > > I realize they are just Q&A forums, but they are what led me to this > conclusion. I see no conclusion, sorry. Ofc we blit the msamples -> 1sample otherwise no result. > > What would you suggest for a better test case? The code I provided shows one > obviously different behavior out of four (At least on affected systems). 1 - Wiki/Faq/Bugreport (full details) 2 - run failing test also w/ full debug props 3- 7z piped out logs and attach w/o reproduction we cannot fix .. you could also try whether a 'glFinish()' _after_ or/and _before_ glReadPixels(..) in GLJPanel solves your problem .. (GPU/driver ..) update driver .. ? thx. ~Sven 3150 7 bkuker 2013-10-19 14:51:32 +0200 Thanks much for the feedback, I appreciate it. I am going to keep looking into this because it affects my users with Java 7 & OSX (because they need to use GLJPanel instead of GLCanvas, this bug is 100% cross platform as you expect) and ATI cards. (In reply to comment #6) > (In reply to comment #5) > > Here are some links: > > > > http://stackoverflow.com/questions/765434/glreadpixels-from-fbo-fails-with- > > multisampling/819463#819463 > > > > http://www.khronos.org/message_boards/showthread.php/7637-How-to-read-Pixel- > > data-from-the-MultiSampled-framebuffer > > > > I realize they are just Q&A forums, but they are what led me to this > > conclusion. > > I see no conclusion, sorry. > > Ofc we blit the msamples -> 1sample > otherwise no result. > So in GLJPanel there are two uses of GLReadPixels to get image data: The first is the one that works: https://github.com/sgothel/jogl/blob/master/src/jogl/classes/javax/media/opengl/awt/GLJPanel.java#L1552 This works because the GLSL flip from the multisampled buffer to the second, non multi-sampled buffer takes the place of blitting from the multisampled buffer. The Second is the one with the problem: https://github.com/sgothel/jogl/blob/master/src/jogl/classes/javax/media/opengl/awt/GLJPanel.java#L1560 Unless I am misreading the code this calls glReadPixels without any kind of blit first. Can you point out where it does? BTW a little more googling make it sound like this is a problem on ATI, and not on NV. 4139 8 sgothel 2014-08-30 18:45:08 +0200 (In reply to comment #7) > So in GLJPanel there are two uses of GLReadPixels to get image data: > > The first is the one that works: > > https://github.com/sgothel/jogl/blob/master/src/jogl/classes/javax/media/ > opengl/awt/GLJPanel.java#L1552 > > This works because the GLSL flip from the multisampled buffer to the second, > non multi-sampled buffer takes the place of blitting from the multisampled > buffer. > > The Second is the one with the problem: > > https://github.com/sgothel/jogl/blob/master/src/jogl/classes/javax/media/ > opengl/awt/GLJPanel.java#L1560 > > Unless I am misreading the code this calls glReadPixels without any kind of > blit first. Can you point out where it does? > > BTW a little more googling make it sound like this is a problem on ATI, and > not on NV. the swap-buffers which also blits/AA the MSAA buffer command is in (current) line 1808 above the glReadPixels(..): <<< if( autoSwapBufferMode ) { // Since we only use a single-buffer non-MSAA or double-buffered MSAA offscreenDrawable, // we can always swap! offscreenDrawable.swapBuffers(); } >>> I see that disabling autoSwap may case issues here .. Does it work for you by now ? Sorry that I have not replied earlier, I was not reading comments on closed reports .. (ping me w/ an additional email next time pls). 4141 9 sgothel 2014-08-30 19:34:32 +0200 Also related Bug 975 and Bug 1020 4145 10 sgothel 2014-08-30 20:04:13 +0200 Test cases: com.jogamp.opengl.test.junit.jogl.acore.TestGLReadBuffer01GLJPanelAWT com.jogamp.opengl.test.junit.jogl.acore.TestGLReadBuffer01GLCanvasAWT com.jogamp.opengl.test.junit.jogl.acore.TestGLReadBuffer01GLWindowNEWT 505 2013-09-25 00:35:02 +0200 2013-09-25 00:35:02 +0200 A test program Bug841.java application/octet-stream 3480 bkuker aW1wb3J0IGphdmEuYXd0LkJvcmRlckxheW91dDsNCg0KaW1wb3J0IGphdmF4Lm1lZGlhLm9wZW5n bC5HTDsNCmltcG9ydCBqYXZheC5tZWRpYS5vcGVuZ2wuR0wyOw0KaW1wb3J0IGphdmF4Lm1lZGlh Lm9wZW5nbC5HTEF1dG9EcmF3YWJsZTsNCmltcG9ydCBqYXZheC5tZWRpYS5vcGVuZ2wuR0xDYXBh YmlsaXRpZXM7DQppbXBvcnQgamF2YXgubWVkaWEub3BlbmdsLkdMRXZlbnRMaXN0ZW5lcjsNCmlt cG9ydCBqYXZheC5tZWRpYS5vcGVuZ2wuR0xQcm9maWxlOw0KaW1wb3J0IGphdmF4Lm1lZGlhLm9w ZW5nbC5hd3QuR0xKUGFuZWw7DQppbXBvcnQgamF2YXguc3dpbmcuSkZyYW1lOw0KaW1wb3J0IGph dmF4LnN3aW5nLkpQYW5lbDsNCmltcG9ydCBqYXZheC5zd2luZy5KUG9wdXBNZW51Ow0KDQovKioN CiAqIFRoaXMgdGVzdCBwcm9ncmFtIGZpbGxzIGluIHRoZSBzY3JlZW4gd2l0aCBhIGRpZmZlcmVu dCBjb2xvciBhbmQgbm90ZXMgdGhhdA0KICogY29sb3IgaW4gdGhlIHRpdGxlIGJhciBpbiB0aGUg b3JkZXINCiAqIA0KICogQmxhY2sgUmVkIEdyZWVuIEJsdWUgUmVkIEdyZWVuIEJsdWUgLiAuIC4N CiAqIA0KICogV2l0aCBhbnkgb2YgdGhlIGZpcnN0IHRocmVlIHNldHRpbmdzIHVuY29tbWVudGVk IHRoZSB0aXRsZSBhbmQgdGhlIGNvbG9yDQogKiBtYXRjaA0KICogDQogKiBXaXRoIHRoZSBmaW5h bCBzZXR0aW5nIHRoZSBpbml0aWFsIEJMQUNLIHNob3dzIGdhcmJhZ2UgZnJvbSB2aWRlbyByYW0g YW5kDQogKiB0aGVuIHRoZSBkaXNwbGF5ZWQgY29sb3IgbGFncyB0aGUgdGl0bGUgYmFyIGNvbG9y IGJ5IG9uZSBjYWxsIHRvIHJlcGFpbnQoKQ0KICogDQogKiBAYXV0aG9yIGJrdWtlcg0KICogDQog Ki8NCnB1YmxpYyBmaW5hbCBjbGFzcyBCdWc4NDEgZXh0ZW5kcyBKRnJhbWUgaW1wbGVtZW50cyBH TEV2ZW50TGlzdGVuZXIgew0KDQoJcHVibGljIHN0YXRpYyB2b2lkIG1haW4oU3RyaW5nW10gYXJn cykgew0KCQlKUG9wdXBNZW51LnNldERlZmF1bHRMaWdodFdlaWdodFBvcHVwRW5hYmxlZChmYWxz ZSk7DQoNCgkJLy8gQW55IG9mIHRoZXNlIHRocmVlIHdvcmsgY29ycmVjdGx5LCBhbmQgdGhlIHNh bWUNCgkJLy8gbmV3IEJ1Zzg0MSh0cnVlLCB0cnVlKTsNCgkJLy8gbmV3IEJ1Zzg0MShmYWxzZSwg dHJ1ZSk7DQoJCS8vIG5ldyBCdWc4NDEoZmFsc2UsIGZhbHNlKTsNCg0KCQkvLyBUaGlzIG9uZSBp cyB0aGUgcHJvYmxlbSBvbmUuDQoJCW5ldyBCdWc4NDEodHJ1ZSwgZmFsc2UpOw0KCX0NCg0KCXBy aXZhdGUgZmxvYXRbXSBjID0gbmV3IGZsb2F0WzNdOw0KDQoJcHVibGljIEJ1Zzg0MShib29sZWFu IGVuYWJsZUFBLCBib29sZWFuIGdsc2wpIHsNCgkJc3VwZXIoIkJ1ZzgyMyIpOw0KCQlzZXRTaXpl KDQwMCwgMzAwKTsNCgkJc2V0RGVmYXVsdENsb3NlT3BlcmF0aW9uKEVYSVRfT05fQ0xPU0UpOw0K CQlKUGFuZWwgcCA9IG5ldyBKUGFuZWwobmV3IEJvcmRlckxheW91dCgpKTsNCg0KCQlpZiAoIWds c2wpIHsNCgkJCVN5c3RlbS5zZXRQcm9wZXJ0eSgiam9nbC5nbGpwYW5lbC5ub2dsc2wiLCAidHJ1 ZSIpOw0KCQl9DQoNCgkJZmluYWwgR0xQcm9maWxlIGdscCA9IEdMUHJvZmlsZS5nZXQoR0xQcm9m aWxlLkdMMik7DQoJCWZpbmFsIEdMQ2FwYWJpbGl0aWVzIGNhcHMgPSBuZXcgR0xDYXBhYmlsaXRp ZXMoZ2xwKTsNCg0KCQlpZiAoZW5hYmxlQUEpIHsNCgkJCWNhcHMuc2V0U2FtcGxlQnVmZmVycyh0 cnVlKTsNCgkJCWNhcHMuc2V0TnVtU2FtcGxlcyg2KTsNCgkJfQ0KDQoJCWZpbmFsIEdMSlBhbmVs IGNhbnZhcyA9IG5ldyBHTEpQYW5lbChjYXBzKTsNCg0KCQljYW52YXMuYWRkR0xFdmVudExpc3Rl bmVyKHRoaXMpOw0KCQlwLmFkZChjYW52YXMsIEJvcmRlckxheW91dC5DRU5URVIpOw0KCQlzZXRD b250ZW50UGFuZShwKTsNCg0KCQlzZXRWaXNpYmxlKHRydWUpOw0KDQoJCWZpbmFsIFN0cmluZyB0 aXRsZSA9ICJBQTogIiArIGVuYWJsZUFBICsgIiBHTFNMOiAiICsgZ2xzbCArICIgIjsNCg0KCQlz ZXRUaXRsZSh0aXRsZSArICJCTEFDSyIpOw0KDQoJCW5ldyBUaHJlYWQoKSB7DQoJCQlwdWJsaWMg dm9pZCBydW4oKSB7DQoJCQkJdHJ5IHsNCgkJCQkJd2hpbGUgKHRydWUpIHsNCgkJCQkJCVRocmVh ZC5zbGVlcCgxMDAwKTsNCg0KCQkJCQkJc2V0VGl0bGUodGl0bGUgKyAiUkVEIik7DQoJCQkJCQlj WzBdID0gMTsNCgkJCQkJCWNbMV0gPSAwOw0KCQkJCQkJY1syXSA9IDA7DQoJCQkJCQlyZXBhaW50 KCk7DQoJCQkJCQlUaHJlYWQuc2xlZXAoMTAwMCk7DQoNCgkJCQkJCXNldFRpdGxlKHRpdGxlICsg IkdSRUVOIik7DQoJCQkJCQljWzBdID0gMDsNCgkJCQkJCWNbMV0gPSAxOw0KCQkJCQkJY1syXSA9 IDA7DQoJCQkJCQlyZXBhaW50KCk7DQoJCQkJCQlUaHJlYWQuc2xlZXAoMTAwMCk7DQoNCgkJCQkJ CXNldFRpdGxlKHRpdGxlICsgIkJMVUUiKTsNCgkJCQkJCWNbMF0gPSAwOw0KCQkJCQkJY1sxXSA9 IDA7DQoJCQkJCQljWzJdID0gMTsNCgkJCQkJCXJlcGFpbnQoKTsNCg0KCQkJCQl9DQoJCQkJfSBj YXRjaCAoSW50ZXJydXB0ZWRFeGNlcHRpb24gZSkgew0KCQkJCQllLnByaW50U3RhY2tUcmFjZSgp Ow0KCQkJCX0NCgkJCX0NCgkJfS5zdGFydCgpOw0KDQoJfQ0KDQoJQE92ZXJyaWRlDQoJcHVibGlj IHZvaWQgZGlzcGxheShHTEF1dG9EcmF3YWJsZSBkcmF3YWJsZSkgew0KCQlHTDIgZ2wgPSBkcmF3 YWJsZS5nZXRHTCgpLmdldEdMMigpOw0KCQlnbC5nbENsZWFyRGVwdGgoMS4wZik7DQoJCWdsLmds Q2xlYXJDb2xvcigwLCAwLCAwLCAxKTsNCgkJZ2wuZ2xDbGVhcihHTC5HTF9DT0xPUl9CVUZGRVJf QklUIHwgR0wuR0xfREVQVEhfQlVGRkVSX0JJVCk7DQoNCgkJZ2wuZ2xDb2xvcjNmdihjLCAwKTsN CgkJZ2wuZ2xEaXNhYmxlKEdMLkdMX0NVTExfRkFDRSk7DQoNCgkJZ2wuZ2xCZWdpbihHTC5HTF9U UklBTkdMRV9TVFJJUCk7DQoJCWdsLmdsTm9ybWFsM2YoMCwgMCwgLTEpOw0KCQlnbC5nbFRleENv b3JkMmYoMCwgMSk7DQoJCWdsLmdsVmVydGV4M2YoLTEsIC0xLCAwKTsNCgkJZ2wuZ2xUZXhDb29y ZDJmKDEsIDEpOw0KCQlnbC5nbFZlcnRleDNmKDEsIC0xLCAwKTsNCgkJZ2wuZ2xUZXhDb29yZDJm KDAsIDApOw0KCQlnbC5nbFZlcnRleDNmKC0xLCAxLCAwKTsNCgkJZ2wuZ2xUZXhDb29yZDJmKDEs IDApOw0KCQlnbC5nbFZlcnRleDNmKDEsIDEsIDApOw0KCQlnbC5nbEVuZCgpOw0KDQoJfQ0KDQoJ QE92ZXJyaWRlDQoJcHVibGljIHZvaWQgaW5pdChHTEF1dG9EcmF3YWJsZSBkcmF3YWJsZSkgew0K CQkvLyBMZWZ0IEJsYW5rDQoJfQ0KDQoJQE92ZXJyaWRlDQoJcHVibGljIHZvaWQgcmVzaGFwZShH TEF1dG9EcmF3YWJsZSBkcmF3YWJsZSwgaW50IHgsIGludCB5LCBpbnQgd2lkdGgsIGludCBoZWln aHQpIHsNCgkJLy8gTGVmdCBCbGFuaw0KCX0NCg0KCUBPdmVycmlkZQ0KCXB1YmxpYyB2b2lkIGRp c3Bvc2UoR0xBdXRvRHJhd2FibGUgZHJhd2FibGUpIHsNCgkJLy8gTGVmdCBCbGFuaw0KCX0NCg0K fQ0K