982 2014-02-23 10:06:11 +0100 TextureIO fails to load some Targa image files 2014-08-04 19:55:25 +0200 1 1 3 JogAmp Jogl util 2 All all RESOLVED INVALID --- minor --- 0 gouessej sgothel gouessej michael.esemplare DEFECT 9d7a7e55c95fcf29ce1ed0804fd7791c1c1147de --- oldest_to_newest 3780 0 gouessej 2014-02-23 10:06:11 +0100 This Targa image file cannot be loaded by TextureIO: https://github.com/Renanse/Ardor3D/blob/master/ardor3d-core/src/main/resources/com/ardor3d/renderer/state/notloaded.tga I get the following stack trace when attempting to load it: java.io.IOException: No suitable reader for given stream at com.jogamp.opengl.util.texture.TextureIO.newTextureDataImpl(TextureIO.java:888) at com.jogamp.opengl.util.texture.TextureIO.newTextureData(TextureIO.java:243) at com.ardor3d.image.util.jogl.JoglImageLoader.load(JoglImageLoader.java:105) at com.ardor3d.image.util.ImageLoaderUtil.loadImage(ImageLoaderUtil.java:77) at com.ardor3d.image.util.ImageLoaderUtil.loadImage(ImageLoaderUtil.java:54) at com.ardor3d.util.TextureManager.loadFromKey(TextureManager.java:207) at com.ardor3d.util.TextureManager.load(TextureManager.java:136) at com.ardor3d.util.TextureManager.load(TextureManager.java:110) at com.ardor3d.renderer.state.TextureState.loadDefaultTexture(TextureState.java:303) at com.ardor3d.renderer.state.TextureState.<init>(TextureState.java:91) at com.ardor3d.example.canvas.RotatingCubeGame.init(RotatingCubeGame.java:83) at com.ardor3d.example.canvas.JoglNewtAwtExample.main(JoglNewtAwtExample.java:130) You can reproduce this bug with the following example: https://github.com/Renanse/Ardor3D/blob/master/ardor3d-examples/src/main/java/com/ardor3d/example/canvas/JoglNewtAwtExample.java You can modify this existing JUnit test to give it a try: https://github.com/sgothel/jogl/blob/master/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/TestTGATextureFromFileNEWT.java 3839 1 michael.esemplare 2014-03-09 08:57:08 +0100 Looking at the TGAImage class and the tga file in question, it seems to be expected... private void decodeImage(GLProfile glp, LEDataInputStream dIn) throws IOException { switch (header.imageType()) { case Header.UCOLORMAPPED: throw new IOException("TGADecoder Uncompressed Colormapped images not supported"); case Header.UTRUECOLOR: // pixelDepth 15, 16, 24 and 32 switch (header.pixelDepth) { case 16: throw new IOException("TGADecoder Compressed 16-bit True Color images not supported"); case 24: case 32: decodeRGBImageU24_32(glp, dIn); break; } break; case Header.UBLACKWHITE: throw new IOException("TGADecoder Uncompressed Grayscale images not supported"); case Header.COLORMAPPED: throw new IOException("TGADecoder Compressed Colormapped images not supported"); case Header.TRUECOLOR: throw new IOException("TGADecoder Compressed True Color images not supported"); case Header.BLACKWHITE: throw new IOException("TGADecoder Compressed Grayscale images not supported"); } } The exception I am thrown is: java.io.IOException: TGADecoder Compressed True Color images not supported at com.jogamp.opengl.util.texture.spi.TGAImage.decodeImage(TGAImage.java:276) at com.jogamp.opengl.util.texture.spi.TGAImage.read(TGAImage.java:373) at com.jogamp.opengl.util.texture.spi.TGAImage.read(TGAImage.java:364) at com.jogamp.opengl.test.junit.jogl.util.texture.TestBug982TGAImageCreateFromData.testImpl(TestBug982TGAImageCreateFromData.java:63) at com.jogamp.opengl.test.junit.jogl.util.texture.TestBug982TGAImageCreateFromData.test00_TGAImage_LoadFromFile(TestBug982TGAImageCreateFromData.java:69) ... 3841 2 gouessej 2014-03-09 16:10:33 +0100 (In reply to comment #1) > Looking at the TGAImage class and the tga file in question, it seems to be > expected... > > private void decodeImage(GLProfile glp, LEDataInputStream dIn) throws > IOException { > switch (header.imageType()) { > case Header.UCOLORMAPPED: > throw new IOException("TGADecoder Uncompressed Colormapped > images not supported"); > > case Header.UTRUECOLOR: // pixelDepth 15, 16, 24 and 32 > switch (header.pixelDepth) { > case 16: > throw new IOException("TGADecoder Compressed 16-bit True > Color images not supported"); > > case 24: > case 32: > decodeRGBImageU24_32(glp, dIn); > break; > } > break; > > case Header.UBLACKWHITE: > throw new IOException("TGADecoder Uncompressed Grayscale images > not supported"); > > case Header.COLORMAPPED: > throw new IOException("TGADecoder Compressed Colormapped images > not supported"); > > case Header.TRUECOLOR: > throw new IOException("TGADecoder Compressed True Color images > not supported"); > > case Header.BLACKWHITE: > throw new IOException("TGADecoder Compressed Grayscale images > not supported"); > } > } > > The exception I am thrown is: > > java.io.IOException: TGADecoder Compressed True Color images not supported > at > com.jogamp.opengl.util.texture.spi.TGAImage.decodeImage(TGAImage.java:276) > at com.jogamp.opengl.util.texture.spi.TGAImage.read(TGAImage.java:373) > at com.jogamp.opengl.util.texture.spi.TGAImage.read(TGAImage.java:364) > at > com.jogamp.opengl.test.junit.jogl.util.texture. > TestBug982TGAImageCreateFromData.testImpl(TestBug982TGAImageCreateFromData. > java:63) > at > com.jogamp.opengl.test.junit.jogl.util.texture. > TestBug982TGAImageCreateFromData. > test00_TGAImage_LoadFromFile(TestBug982TGAImageCreateFromData.java:69) > ... Thank you for investigating. There is a lack to support for RLE compression in TGAImage, "truecolor" is already supported. 3842 3 gouessej 2014-03-09 16:32:05 +0100 (In reply to comment #1) > > case Header.COLORMAPPED: > throw new IOException("TGADecoder Compressed Colormapped images > not supported"); > > case Header.TRUECOLOR: > throw new IOException("TGADecoder Compressed True Color images > not supported"); > > case Header.BLACKWHITE: > throw new IOException("TGADecoder Compressed Grayscale images > not supported"); > } > } > > The exception I am thrown is: > > java.io.IOException: TGADecoder Compressed True Color images not supported > at > com.jogamp.opengl.util.texture.spi.TGAImage.decodeImage(TGAImage.java:276) > at com.jogamp.opengl.util.texture.spi.TGAImage.read(TGAImage.java:373) > at com.jogamp.opengl.util.texture.spi.TGAImage.read(TGAImage.java:364) > at > com.jogamp.opengl.test.junit.jogl.util.texture. > TestBug982TGAImageCreateFromData.testImpl(TestBug982TGAImageCreateFromData. > java:63) > at > com.jogamp.opengl.test.junit.jogl.util.texture. > TestBug982TGAImageCreateFromData. > test00_TGAImage_LoadFromFile(TestBug982TGAImageCreateFromData.java:69) > ... Which version of JOGL do you use? RLE support was added in 2013 in this class, only 16-bits compressed truecolor TGA files are still unsupported: https://github.com/sgothel/jogl/blob/master/src/jogl/classes/com/jogamp/opengl/util/texture/spi/TGAImage.java#L279 The Gimp doesn't give me a lot of information about the image data :s 3843 4 gouessej 2014-03-09 16:48:11 +0100 "For 16 bits each colour component is stored as 5 bits and the remaining bit is a binary alpha value." http://www.paulbourke.net/dataformats/tga/ It matches with this format: http://jogamp.org/deployment/jogamp-next/javadoc/jogl/javadoc/javax/media/opengl/GL.html#GL_RGB5_A1 3845 5 606 michael.esemplare 2014-03-09 23:30:06 +0100 Created attachment 606 Test case for targa image Thanks for pointing that out, I didn't realize I was using a much older version. The unit test passes against master and 2.1.4. I have attached the test if you wish to run. 4015 6 sgothel 2014-07-10 14:05:19 +0200 9d7a7e55c95fcf29ce1ed0804fd7791c1c1147de: Added RLE32 tga file to be tested w/ pre-existing unit test TestTGATextureFromFileNEWT. As mentioned above - not a bug, all works. 4025 7 gouessej 2014-07-12 23:58:06 +0200 Sorry but it doesn't work with the image I mentioned in my very first post: https://github.com/Renanse/Ardor3D/blob/master/ardor3d-core/src/main/resources/com/ardor3d/renderer/state/notloaded.tga JFPSM still complains: [java] juil. 12, 2014 10:52:22 PM com.ardor3d.util.resource.ResourceLocatorTool locateResource [java] Avertissement: Unable to locate: file:/home/gouessej/Documents/programmation/java/workspace/tuer/md2/soldier.md2 [java] juil. 12, 2014 10:52:22 PM com.ardor3d.util.TextureManager load [java] Avertissement: Could not load image... source was null. defaultTexture used. [java] libEGL warning: failed to create a pipe screen for i965 [java] juil. 12, 2014 10:52:29 PM com.ardor3d.image.util.ImageLoaderUtil loadImage [java] Avertissement: Could not load Image. [java] java.io.IOException: No suitable reader for given stream [java] at com.jogamp.opengl.util.texture.TextureIO.newTextureDataImpl(TextureIO.java:851) [java] at com.jogamp.opengl.util.texture.TextureIO.newTextureData(TextureIO.java:245) [java] at com.ardor3d.image.util.jogl.JoglImageLoader.load(JoglImageLoader.java:105) [java] at com.ardor3d.image.util.ImageLoaderUtil.loadImage(ImageLoaderUtil.java:77) [java] at com.ardor3d.image.util.ImageLoaderUtil.loadImage(ImageLoaderUtil.java:54) [java] at com.ardor3d.util.TextureManager.loadFromKey(TextureManager.java:207) [java] at com.ardor3d.util.TextureManager.load(TextureManager.java:136) [java] at com.ardor3d.util.TextureManager.load(TextureManager.java:110) [java] at com.ardor3d.renderer.state.TextureState.loadDefaultTexture(TextureState.java:303) [java] at com.ardor3d.renderer.state.TextureState.getDefaultTexture(TextureState.java:292) [java] at com.ardor3d.util.TextureManager.load(TextureManager.java:131) [java] at com.ardor3d.util.TextureManager.load(TextureManager.java:93) [java] at com.ardor3d.extension.model.md2.Md2Importer.loadTexture(Md2Importer.java:356) [java] at com.ardor3d.extension.model.md2.Md2Importer.load(Md2Importer.java:337) [java] at jfpsm.ModelConverterViewer$ModelConversionSwingWorker.doInBackground(ModelConverterViewer.java:371) [java] at jfpsm.ModelConverterViewer$ModelConversionSwingWorker.doInBackground(ModelConverterViewer.java:318) [java] at javax.swing.SwingWorker$1.call(SwingWorker.java:296) [java] at java.util.concurrent.FutureTask.run(FutureTask.java:262) [java] at javax.swing.SwingWorker.run(SwingWorker.java:335) [java] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [java] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [java] at java.lang.Thread.run(Thread.java:744) [java] juil. 12, 2014 10:52:29 PM com.ardor3d.util.TextureManager loadFromKey [java] Avertissement: (image null) Could not load: URLResourceSource [url=jar:file:/home/gouessej/Documents/programmation/java/workspace/tuer/lib/ardor3d/ardor3d-core-1.0-SNAPSHOT.jar!/com/ardor3d/renderer/state/notloaded.tga, type=.tga] 4027 8 gouessej 2014-07-14 15:51:20 +0200 I've just added the problematic image into the unit test: https://github.com/sgothel/jogl/pull/78 It seems to work but I still get an exception. It probably exhibits another bug elsewhere. 4060 9 gouessej 2014-07-31 21:27:48 +0200 In JoglImageLoader, I do this: final TextureData textureData = TextureIO.newTextureData(_capsUtil.getProfile(), is, true, null); It has no chance to work with TGA because of this test in TGATextureProvider: if (TGA.equals(fileSuffix)) { I don't know yet how I'll work around this limitation. 4061 10 gouessej 2014-07-31 22:51:21 +0200 Feel free to close this bug as invalid. The image I provided in in true color 32 bits, the problem comes from Ardor3D except if we consider that JOGL should be able to guess which image type contains the passed input stream (with a file suffix set to null). I'll implement this mechanism in Ardor3D, maybe we should move it into JOGL itself, it should be the subject of a distinct bug report. 4062 11 gouessej 2014-08-02 23:57:18 +0200 The real bug has been fixed in Ardor3D: https://github.com/gouessej/Ardor3D/blob/master/ardor3d-jogl/src/main/java/com/ardor3d/image/util/jogl/JoglImageLoader.java#L148 Sven, please tell me whether this kind of thing should be moved into JOGL. My bug report is invalid as JOGL's TGA loader was already able to load the default image used in Ardor3D since the very beginning. Ardor3D AWT image loader was the only loader able to "guess" the image format until I fixed that in com.ardor3d.image.util.jogl.JoglImageLoader. 4069 12 sgothel 2014-08-04 19:52:45 +0200 (In reply to comment #11) > The real bug has been fixed in Ardor3D: > https://github.com/gouessej/Ardor3D/blob/master/ardor3d-jogl/src/main/java/ > com/ardor3d/image/util/jogl/JoglImageLoader.java#L148 > > Sven, please tell me whether this kind of thing should be moved into JOGL. > > My bug report is invalid as JOGL's TGA loader was already able to load the > default image used in Ardor3D since the very beginning. Ardor3D AWT image > loader was the only loader able to "guess" the image format until I fixed > that in com.ardor3d.image.util.jogl.JoglImageLoader. That would be _excellent_, i.e. the image format auto-detection! IMHO it would be nice to have a static method returning the type, as well as an overloaded 'load' texture method. Nice! I will cherry pick your lines and commit as you as author. 4071 13 sgothel 2014-08-04 19:55:25 +0200 (In reply to comment #12) > > Nice! > > I will cherry pick your lines and commit as you as author. Bug 1042 606 2014-03-09 23:30:06 +0100 2014-03-09 23:30:06 +0100 Test case for targa image TestBug982TGAImageReadFromFile.java text/x-java 1763 michael.esemplare cGFja2FnZSBjb20uam9nYW1wLm9wZW5nbC50ZXN0Lmp1bml0LmpvZ2wudXRpbC50ZXh0dXJlOw0K DQppbXBvcnQgamF2YS5pby5GaWxlOw0KaW1wb3J0IGphdmEuaW8uRmlsZUlucHV0U3RyZWFtOw0K aW1wb3J0IGphdmEuaW8uSU9FeGNlcHRpb247DQppbXBvcnQgamF2YS5uZXQuVVJJU3ludGF4RXhj ZXB0aW9uOw0KaW1wb3J0IGphdmEubmV0LlVSTDsNCmltcG9ydCBqYXZhLm5ldC5VUkxDb25uZWN0 aW9uOw0KaW1wb3J0IGphdmEubmlvLkJ5dGVCdWZmZXI7DQoNCmltcG9ydCBqYXZheC5tZWRpYS5v cGVuZ2wuR0w7DQppbXBvcnQgamF2YXgubWVkaWEub3BlbmdsLkdMUHJvZmlsZTsNCg0KaW1wb3J0 IG9yZy5qdW5pdC5BZnRlcjsNCmltcG9ydCBvcmcuanVuaXQuQXNzZXJ0Ow0KaW1wb3J0IG9yZy5q dW5pdC5CZWZvcmU7DQppbXBvcnQgb3JnLmp1bml0LlRlc3Q7DQoNCmltcG9ydCBjb20uam9nYW1w LmNvbW1vbi51dGlsLklPVXRpbDsNCmltcG9ydCBjb20uam9nYW1wLm9wZW5nbC51dGlsLnRleHR1 cmUuc3BpLkREU0ltYWdlOw0KaW1wb3J0IGNvbS5qb2dhbXAub3BlbmdsLnV0aWwudGV4dHVyZS5z cGkuVEdBSW1hZ2U7DQppbXBvcnQgY29tLmpvZ2FtcC5vcGVuZ2wudXRpbC50ZXh0dXJlLnNwaS5E RFNJbWFnZS5JbWFnZUluZm87DQoNCnB1YmxpYyBjbGFzcyBUZXN0QnVnOTgyVEdBSW1hZ2VSZWFk RnJvbUZpbGUgew0KCQ0KCUZpbGUgdGVzdFRHQUltYWdlMDE7DQoJc3RhdGljIEdMUHJvZmlsZSBn bHAgPSBHTFByb2ZpbGUuZ2V0RGVmYXVsdCgpOw0KCQ0KCUBCZWZvcmUNCiAgICBwdWJsaWMgdm9p ZCBzZXR1cCgpIHRocm93cyBUaHJvd2FibGUgew0KCQl0ZXN0VEdBSW1hZ2UwMSA9IGluaXRGaWxl KCJub3Rsb2FkZWQudGdhIik7DQogICAgfQ0KCQ0KICAgIEBBZnRlcg0KICAgIHB1YmxpYyB2b2lk IHRlYXJkb3duKCkgew0KICAgIAl0ZXN0VEdBSW1hZ2UwMSA9IG51bGw7DQogICAgfQ0KICAgIA0K ICAgIHByaXZhdGUgRmlsZSBpbml0RmlsZShTdHJpbmcgZmlsZW5hbWUpIHRocm93cyBVUklTeW50 YXhFeGNlcHRpb24gew0KICAgIAlVUkxDb25uZWN0aW9uIGNvbm5lY3Rpb24gPSBJT1V0aWwuZ2V0 UmVzb3VyY2UoZ2V0Q2xhc3MoKSwgZmlsZW5hbWUpOw0KICAgIAlBc3NlcnQuYXNzZXJ0Tm90TnVs bChjb25uZWN0aW9uKTsNCiAgICAJVVJMIHVybCA9IGNvbm5lY3Rpb24uZ2V0VVJMKCk7DQogICAg CUZpbGUgZmlsZSA9IG5ldyBGaWxlKHVybC50b1VSSSgpKTsNCiAgICAJQXNzZXJ0LmFzc2VydFRy dWUoZmlsZS5leGlzdHMoKSk7DQogICAgCXJldHVybiBmaWxlOw0KICAgIH0NCiAgICANCiAgICBw cml2YXRlIHZvaWQgdGVzdEltcGwoRmlsZSBmaWxlKSB0aHJvd3MgSU9FeGNlcHRpb24gew0KICAg IAlUR0FJbWFnZSB0Z2FJbWFnZSA9IFRHQUltYWdlLnJlYWQoZ2xwLCBuZXcgRmlsZUlucHV0U3Ry ZWFtKHRlc3RUR0FJbWFnZTAxKSk7DQogICAgCUFzc2VydC5hc3NlcnROb3ROdWxsKHRnYUltYWdl KTsNCiAgICB9DQogICAgDQogICAgDQogICAgQFRlc3QNCiAgICBwdWJsaWMgdm9pZCB0ZXN0MDBf VEdBSW1hZ2VfUmVhZEZyb21GaWxlICgpIHRocm93cyBJT0V4Y2VwdGlvbiB7DQogICAgCXRlc3RJ bXBsKHRlc3RUR0FJbWFnZTAxKTsNCiAgICB9DQogICAgDQoJcHVibGljIHN0YXRpYyB2b2lkIG1h aW4oU3RyaW5nW10gYXJncykgew0KCQlvcmcuanVuaXQucnVubmVyLkpVbml0Q29yZS5tYWluKFRl c3RCdWc5ODJUR0FJbWFnZVJlYWRGcm9tRmlsZS5jbGFzcy5nZXROYW1lKCkpOw0KCX0NCn0=