Bug 1280 - WAV files with appended metadata incorrectly loaded
Summary: WAV files with appended metadata incorrectly loaded
Status: RESOLVED FIXED
Alias: None
Product: Joal
Classification: JogAmp
Component: core (show other bugs)
Version: 2.4.0
Hardware: All all
: P4 normal
Assignee: Xerxes Rånby
URL:
Depends on:
Blocks:
 
Reported: 2016-01-06 16:57 CET by Matt Harris
Modified: 2019-03-26 22:49 CET (History)
2 users (show)

See Also:
Type: DEFECT
SCM Refs:
joal 52ae4377ddc9676fda5eb8f9ac5d93b0521e8aba
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Harris 2016-01-06 16:57:08 CET 
Certain WAV files have metadata appended after the 'data' chunk.

With the current implementation, this metadata is loaded as part of the sample data and result in a short burst of noise at the end of the sample.
Comment 1 Matt Harris 2016-01-06 17:06:00 CET 
See PR https://github.com/sgothel/joal/pull/15 for proposed fix
Comment 2 Julien Gouesse 2016-01-07 09:38:06 CET 
Your patch is ok for me.
Comment 3 Julien Gouesse 2016-02-16 19:59:41 CET 
Xerxes, please can you look at his patch?
Comment 4 Sven Gothel 2019-03-26 22:49:05 CET 
Thank you very much Matt.

I merged your pull request (finally).