Changes

SWTAccessor: Cleanup disable debug messages

Removing also all the double quotes
https://jogamp.org/bugzilla/show_bug.cgi?id=1283

Bug 1254: Fix viewport height in BCM VC IV ScreenDriver
This should fix https://jogamp.org/bugzilla/show_bug.cgi?id=1254, which
leads to windowed sketches not being centered in Processing.

Improved layout of last paragraph in class javadoc

Typo in javadoc of GLDrawable#isRealized

add touch event support for x11 server

Fix mouse button reporting in X11UnderlayTracker

Fix overlay/underlay position mismatch in X11UnderlayTracker with
overscan enabled
With the overscan enabled by the Raspberry Pi firmware, which seems to
be the default for some attached displays, the underlayWindow size will
be e.g. 1888x1048 (retrieved from X11), whereas the overlayWindow size
remains at 1920x1080 (retrieved from the Broadcom VC IV implementation).
This causes the overlay window to be visually offset by a few pixels.
Correct this by applying an offset when the two don't match. (Both
displays are assumed to have the same center.)

Update GLContextImpl.java

osx test scripts using latest Java

OSX/Newt: Catch NSRangeException on closing a window
rarely occurs on terminating or killing the process

Eclipse: Move android.jar to classpath end, avoid junit override

JavaFX: Adding JavaFX Support for NEWT utilizing native Window parenting
via NewtCanvasJFX
NewtCanvasJFX, a JavaFX Canvas Node, allows attaching a native NEWT
Window to the JavaFX Node's native Window (if attached).
The mechanism is similar to NewtCanvasAWT.
Current implementation supports placing the NEWT Window into the JavaFX
scene of the native window correctly, as well as the following different
lifecycles
- attach NewtCanvasJFX to already visible group->scene->window
- attach NewtCanvasJFX to not yet visible or attached
group->scene->window
- attach NEWT Window before or after NewtCanvasJFX's visibility
The above is covered by unit test: TestNewtCanvasJFXGLn
This is the initial commit for JavaFX support and has been tested on
- OpenJDK 8 + OpenJFX 8
- GNU/Linux X11

JavaFX: Fix API doc of JFXAccessor

JavaFX: Remove JFXAccessor redundancy

JavaFX: Add proper class doc for implementation and unit test

JavaFX: Preliminary testing on Windows

NewtCanvasJFX: Clarify [dispose() -> destroy()] operation
This is automatically issued when receiving the
javafx.stage.WindowEvent#WINDOW_CLOSE_REQUEST from the attached
top-level JavaFX Window

NewtCanvasJFX: Implement WindowClosingProtocol.WindowClosingMode
Behavior

NewtCanvasSWT: Fix NOP WindowClosingProtocol.WindowClosingMode Behavior

Adding NativeWindowHolder extends NativeSurfaceHolder; API Doc for
NEWTDemoListener
NativeWindowHolder abstracts access to is-a or has-a parent component's
NativeWindow like NewtCanvasAWT, NewtCanvasJFX and NewtCanvasSWT
Adding API Doc for NEWTDemoListener.

Tests: Adding API Doc for test utilizing NEWTDemoListener and
derivations

TestNewtCanvasJFXGLn: Adding NEWTDemoListener and
NewtJFXReparentingKeyAdapter functionality

NewtCanvasJFX.NativeWindow: Delegate required child window canvas
position
NewtCanvasJFX.NativeWindow shall pass through NewtCanvasJFX's Canvas
position to properly position the NEWT child window inside the top level
Window.
NewtJFXReparentingKeyAdapter demonstrating manual reparenting
demonstrates this case.
TestGearsES2NewtCanvasAWT's default behavior is to use a surrounding
border for the NEWTCanvasAWT child, similar to TestNewtCanvasJFXGLn.

NewtCanvasJFX: Utilize JFXEDTUtil per default, supporting the Windows
Platform
On [GNU/Linux] X11 JFXEDTUtil is not required, since X11 can handle
multi-threaded native parenting, however, the Windows platform does
require JFXEDTUtil.
Currently the default is to use JFXEDTUtil, which operates solely on the
JavaFX thread for windowing lifecycle and even-dispatch operations.
This behavior can be toggled via the boolean property
'jogamp.newt.javafx.UseJFXEDT', which currently defaults to 'true'
This behavior might be analyzed in more detail for a fine grained
EDTUtil decision.

Bug 1357 Related: GLRendererQuirks NoSetSwapIntervalPostRetarget and
NoDoubleBufferedPBuffer no more required for Mesa >= 18.2.2

Bug 1283: Remove shader include filename quotes if exists at start and
end only

ShaderCode: Fixed constant usage (GL3 -> GL3ES3)

Bug 1288: GLBufferStateTracker needs to support ARB_indirect_parameters
GLBufferStateTracker needs to support ARB_indirect_parameters, i.e.
checkTargetName(target) and getQueryName(target) need to recognize
GL4.GL_PARAMETER_BUFFER_ARB.

Bug 1348: X11 XI Multitouch: Fixes of previous commit
92006e4baef57f1f3fb647dd307aed5989fd4c8d
Previous commit 92006e4baef57f1f3fb647dd307aed5989fd4c8d
(Note to Danny: I cannot test this now - please re-test and/or review)
X11Common::JavaWindow
- Owns XI extension's xiOpcode, selected xiTouchDeviceId and tracked
XITouchPosition array
X11Window::CreateWindow
- Query XI extension only once @ window creation and earmark xiOpcode in
JavaWindow instance
- Fix: Device selection code was "class->type != XITouchClass",
 but shouldn't it be 'XITouchClass == class->type' (as patched here)
- Fix: Free XIQueryDevice returned XIDeviceInfo array via
XIFreeDeviceInfo
- Earmark deviceid in JavaWindow instance
X11Display
- Moved global static touch_coordinates to JavaWindow::xiTouchCoords
instance
X11Display::DispatchMessage
- Changed event handling structure similar to
https://keithp.com/blogs/Cursor_tracking/
- Fix: Free XGetEventData's optional memory allocation via
XFreeEventData
- Reuse JavaWindow's queried xiOpcode
- Fix: Don't overrise windowPointer, instead validate and require a
match. JavaWindow must match!
- Fix: Also validate chosen deviceid with JavaWindow's registered device
Newt Build:
- Added libXi in build recipe and doc

Bug 1348: X11 XI Multitouch: Refine commit
746383476aa449e9cab4a25df27be85b61aa074b
Add more verbose DBG_PRINT
- @ CreateWindow: extension, scanning device/class, registered deviceid
- @ DispatchMessage: XI_TouchBegin, XI_TouchUpdate and XI_TouchEnd
On my test machine w/o a touchscreen I correctly:
- detected extension
- detected no XITouchClass device, hence no deviceid registered
X11: [CreateWindow]: XI: Window 0x6600016, Extension 131 X11:
[CreateWindow]: XI: Scan Window 0x6600016, device[1/13].class[1/7]: type
1 (is XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[1/13].class[2/7]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[1/13].class[3/7]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[1/13].class[4/7]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[1/13].class[5/7]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[1/13].class[6/7]: type 3 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[1/13].class[7/7]: type 3 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[2/13].class[1/1]: type 0 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[3/13].class[1/3]: type 1 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[3/13].class[2/3]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[3/13].class[3/3]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[4/13].class[1/1]: type 0 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[5/13].class[1/1]: type 0 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[6/13].class[1/1]: type 0 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[7/13].class[1/1]: type 0 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[8/13].class[1/7]: type 1 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[8/13].class[2/7]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[8/13].class[3/7]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[8/13].class[4/7]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[8/13].class[5/7]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[8/13].class[6/7]: type 3 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[8/13].class[7/7]: type 3 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[9/13].class[1/7]: type 1 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[9/13].class[2/7]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[9/13].class[3/7]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[9/13].class[4/7]: type 2 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[9/13].class[5/7]: type 2 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[9/13].class[6/7]: type 3 (is XITouchClass 0) X11: [CreateWindow]:
XI: Scan Window 0x6600016, device[9/13].class[7/7]: type 3 (is
XITouchClass 0) X11: [CreateWindow]: XI: Scan Window 0x6600016,
device[10/13].class[1/1]: type 0 (is XITouchClass 0) X11:
[CreateWindow]: XI: Scan Window 0x6600016, device[11/13].class[1/1]:
type 0 (is XITouchClass 0) X11: [CreateWindow]: XI: Scan Window
0x6600016, device[12/13].class[1/7]: type 1 (is XITouchClass 0) X11:
[CreateWindow]: XI: Scan Window 0x6600016, device[12/13].class[2/7]:
type 2 (is XITouchClass 0) X11: [CreateWindow]: XI: Scan Window
0x6600016, device[12/13].class[3/7]: type 2 (is XITouchClass 0) X11:
[CreateWindow]: XI: Scan Window 0x6600016, device[12/13].class[4/7]:
type 2 (is XITouchClass 0) X11: [CreateWindow]: XI: Scan Window
0x6600016, device[12/13].class[5/7]: type 2 (is XITouchClass 0) X11:
[CreateWindow]: XI: Scan Window 0x6600016, device[12/13].class[6/7]:
type 3 (is XITouchClass 0) X11: [CreateWindow]: XI: Scan Window
0x6600016, device[12/13].class[7/7]: type 3 (is XITouchClass 0) X11:
[CreateWindow]: XI: Scan Window 0x6600016, device[13/13].class[1/1]:
type 0 (is XITouchClass 0)

Update HowToBuild.html
Minimum supported Debian version is now Debian 9 or Stretch to minimize
maintenance. Note: No other GNU/Linux version has been validated so far.

Bug 1348: Fix X11 XI Multitouch
I got access to a touchscreen laptop w/ Debian 9, hence I could fix and
test the implementation.
X11 DisplayDriver.java:
- Store and pass through xi_opcode of XI extension, queried at
initialization stage
X11Window.c Fixes:
- Initialize JavaWindow's xiTouchCoords[].id w/ -1, as required to track
the pointer
- Pass through xi_opcode as stored in X11 DisplayDriver
X11Display.c Fixes:
- sendTouchScreenEvent: Throw RuntimeException if 0 > actionId (Internal
Error: based on xiTouchCoords[].id tracking)
- DispatchMessages's windowPointer determination:
-- Query potenial XI Event first: IF XI Event, must use XIDeviceEvent's
event Window
-- Only IF not an XI Event, we can use evt.xany.window as the event
window
- DispatchMessages's XI Event Handling:
-- Always break deviceid search loop if id found, preserving index and
time spend
Works on my Debian 9 device, tested w/
com.jogamp.opengl.test.junit.jogl.demos.es2.newt.TestGearsES2NEWT:
- One pointer (finger) press, drag and release (click)
- PinchToZoomGesture works
- DoubleTabScrollGesture works
+++
Potential Issues:
JavaWindow's xiTouchCoords[].id accuracy is crucial to pointer tracking 
during XI_TouchBegin -> XI_TouchUpdate -> XI_TouchEnd.
In the normal course of action:
- XI_TouchBegin sets the id, assuming it is yet set
- XI_TouchUpdate assumes it is set
- XI_TouchEnd clears the id, assuming it is set
This field in the JavaWindow array only gets reset to -1 once at native
window creation. We may need to figure out when to reset this field to
-1.
If the XI_TouchEnd events would get lost for whatever reason, the above
tracking state would be broken.

Bug 1316: MacOSX: Keep *.dylib (Don't move to *.jnilib)
Since Java8 (or even earlier), JRE on OSX uses *.dylib native library
suffix instead of *.jnilib when automatically searching and loading
them.
This is not easily being recognized by JogAmp, since we explicitly name 
the native libraries with full path when testing with our TempJarCache.

Bug 1366 - Use String.format((Locale)null, "..." ..) avoiding Locale
output for System related Operations

Bug 1367: Adapt to TempFileCache & TempJarCache Changes

Bug 1367: Adapt to TempFileCache & TempJarCache Changes

Windows scripts: Use JDK/JRE 1.8.0_121

TestVersionSemanticsNOUI: Adapt to upcoming NON_BACKWARD_COMPATIBLE
version 2.4.0

Bug 1370: Call from Main-Thread: NW's OSXUtil.CreateNSWindow0(..) and
NEWT's WindowDriver.createWindow0(..)
OSX 10.14.3 Mojave issues a WARNING: NSWindow drag regions should only
be invalidated on the Main Thread! This will throw an exception in the
future.
The complaint about NativeWindow (NW)'s OSXUtil.CreateNSWindow0(..) 
might be valid, which does create a NS Window instance w/ NSView and
framebuffer initialized.
However, the complaint about NEWT's WindowDriver.createWindow0(..) is
not, since the initialization incl framebuffer happened later on the
main thread.
Regardless, encapsulated both construction fully to run on the
Main-Thread.
+++
Originally the Main-Thread design spec was like: Must run on Main-Thread
when or after making visible.
Oh well.

Bug 1362: Enhancing SWT/GTK Support for GTK 2.90, SWT > 4.8 (?)

Bug 1362: Replace SWT 4.3.0 -> 4.11.0
https://download.eclipse.org/eclipse/downloads/drops4/R-4.11-201903070500/
This binary make/lib drop is only required for build and unit tests.

Bug 1362: build/test: Use new SWT 4.10 swt.jar (instead of
swt-debug.jar)

Bug 1362: SWTAccessor: c -> cGTK for readability

Bug 1362: Test against SWT 4.3 and 4.11
4.3 is still working w/ GTK2 4.11 is not working as described by Wade

Bug 1362: Wrong 'fake' swt.jar config for isLinuxARM64, isLinuxARMv6 and
isAndroid
We intend to attach a non-matching swt.jar for these build nodes, to at
least pass the javac pass w/o testing on those platforms.