SuccessChanges

Summary

  1. X11: Harden usage of 'XGetWindowProperty(..)' and 'XGetVisualInfo' - Add (details)
  2. [Jogl|Nativewindow|Newt]Common: Align all (details)
  3. Misc Cleanup: JAWTWindow: Reusing visible in HIERARCHY listener; Remove (details)
  4. Fix GLDrawableHelper.resizeOffscreenDrawable(..): Do nothing if (details)
  5. Bug 937 - JAWTWindow: Unsatisfying Visibility Computation (details)
  6. AWTParentWindowAdapter/AWTRobotUtil: Use 'isShowing()' instead of (details)
  7. DefaultEDTUtil: At EDT finish, notify all task-waiter to avoid deadlock (details)
  8. JOGLNewtAppletBase: Typo of new PNG icons .. used AE's 'gray' instead of (details)
  9. JAWTWindow.JAWTComponentListener: Minor Cleanup (details)
  10. OSXMisc CALayer::FixCALayerLayout: Fix visible:=false case, i.e. don'r (details)
Commit 5ef83c2b8576ccd764ffc4953eea506bd96277c3 by Sven Gothel
X11: Harden usage of 'XGetWindowProperty(..)' and 'XGetVisualInfo' - Add missing XFree(..) calls and argument checks.
The file was modifiedsrc/newt/native/X11Window.c (diff)
The file was modifiedsrc/nativewindow/native/x11/Xmisc.c (diff)
Commit 6647b4a63866a554c738e0b7b61e6dc40a6fb511 by Sven Gothel
[Jogl|Nativewindow|Newt]Common: Align all *Common_GetJNIEnv()/_ReleaseJNIEnv() Methods and Usage / Check arguments ..

Since we still don't use inter-module native code sharing, align the JNIEnv get/release methods and usage.

Most beneficary here is OSX and the GLDebugMessageHandle,
both managed the JVM handle on their own - removed now.

Also ensuring that *Common_init(..) is called for all modules on all platforms.
The file was modifiedsrc/newt/native/MacWindow.m (diff)
The file was modifiedsrc/newt/native/NewtCommon.h (diff)
The file was modifiedsrc/newt/native/NewtMacWindow.m (diff)
The file was modifiedsrc/jogl/native/GLContext.c (diff)
The file was modifiedsrc/jogl/native/GLDebugMessageHandler.c (diff)
The file was modifiedsrc/nativewindow/native/macosx/OSXmisc.m (diff)
The file was modifiedsrc/nativewindow/native/x11/Xmisc.c (diff)
The file was modifiedsrc/newt/native/NewtCommon.c (diff)
The file was modifiedsrc/jogl/native/openmax/jogamp_opengl_util_av_impl_OMXGLMediaPlayer.c (diff)
The file was modifiedsrc/jogl/native/macosx/MacOSXWindowSystemInterface-calayer.m (diff)
The file was modifiedsrc/jogl/native/JoglCommon.h (diff)
The file was modifiedsrc/jogl/native/libav/ffmpeg_impl_template.c (diff)
The file was modifiedsrc/jogl/native/JoglCommon.c (diff)
The file was modifiedsrc/nativewindow/native/win32/GDImisc.c (diff)
The file was modifiedsrc/nativewindow/native/NativewindowCommon.h (diff)
The file was modifiedsrc/newt/native/NewtMacWindow.h (diff)
The file was modifiedsrc/nativewindow/native/NativewindowCommon.c (diff)
Commit 6ea03078e162eed89653ae123d172b6fca7c6d61 by Sven Gothel
Misc Cleanup: JAWTWindow: Reusing visible in HIERARCHY listener; Remove obsolete 'getPrivateGraphicsConfiguration()'
The file was modifiedsrc/jogl/classes/jogamp/opengl/GLFBODrawableImpl.java (diff)
The file was modifiedsrc/nativewindow/classes/com/jogamp/nativewindow/awt/JAWTWindow.java (diff)
The file was modifiedsrc/newt/classes/jogamp/newt/WindowImpl.java (diff)
The file was modifiedsrc/jogl/classes/jogamp/opengl/GLDrawableHelper.java (diff)
The file was modifiedsrc/nativewindow/classes/jogamp/nativewindow/ProxySurfaceImpl.java (diff)
Commit cf75fbde9f7081bb253eff2bb8f36a39992352e1 by Sven Gothel
Fix GLDrawableHelper.resizeOffscreenDrawable(..): Do nothing if !drawable.isRealized() - similar to it's recreateDrawable() and test only _after_ having the surface lock!

Only after the surface lock we are thread safe.

In case drawable has been pulled, do nothing ..
The file was modifiedsrc/jogl/classes/jogamp/opengl/GLDrawableHelper.java (diff)
Commit 071bdd6ce9f8c41ccecdbf8bc74f276ccd7ff651 by Sven Gothel
Bug 937 - JAWTWindow: Unsatisfying Visibility Computation

Simplify JAWTComponentListener's HierarchyListener:
  - Don't interfere w/ Component's visibility anymore!
    This shall reduce sideeffects.
    Utilize 'isShowing' in each Component specialization, i.e. GLCanvas.

  - On SHOWING_CHANGED if a parent caused a change
    of the tracked components showing state,
    propagate it to the offscreen-layer!

  - Remove all other complicated states!

GLCanvas, GLJPanel:
  - Instead of 'isVisible()' use 'showing state',
    since only the 'showing state' reflects 'true' visibility
    throughout the hierarchy.

  - Add HierarchyListener and track volatile showing state
    to be used instead of 'isVisible'.
    Using a cached showing state is more efficient
    than quering 'isShowing()' all the time!

NewtCanvasAWT:
  - Use 'isShowing()' instead of 'isVisible(), see above
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/awt/TestBug816JTabbedPanelVisibilityB849B878AWT.java (diff)
The file was modifiedmake/scripts/tests.sh (diff)
The file was modifiedsrc/jogl/classes/javax/media/opengl/awt/GLJPanel.java (diff)
The file was modifiedsrc/newt/classes/com/jogamp/newt/awt/NewtCanvasAWT.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/awt/TestBug816OSXCALayerPos03bB849AWT.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/awt/TestBug816OSXCALayerPos03cB849AWT.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/acore/anim/TestAWTCardLayoutAnimatorStartStopBug532.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/awt/TestBug664GLCanvasSetVisibleSwingAWT.java (diff)
The file was modifiedsrc/nativewindow/classes/com/jogamp/nativewindow/awt/JAWTWindow.java (diff)
The file was modifiedsrc/jogl/classes/javax/media/opengl/awt/GLCanvas.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/awt/TestBug816OSXCALayerPos03aB729AWT.java (diff)
Commit d2f50f2ed523aa8443f647e46aeecc09fa27583d by Sven Gothel
AWTParentWindowAdapter/AWTRobotUtil: Use 'isShowing()' instead of 'isVisible()' determining actual on-screen showing state

See commit 071bdd6ce9f8c41ccecdbf8bc74f276ccd7ff651
The file was modifiedsrc/newt/classes/jogamp/newt/awt/event/AWTParentWindowAdapter.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/util/AWTRobotUtil.java (diff)
Commit 45160297725fa3688b6c9dccb1d7c3095c2ca773 by Sven Gothel
DefaultEDTUtil: At EDT finish, notify all task-waiter to avoid deadlock at error / Add test method 'invokeAndWaitError(..)'
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/jogl/demos/es2/newt/TestGearsES2NEWT.java (diff)
The file was modifiedsrc/newt/classes/jogamp/newt/DefaultEDTUtil.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/util/QuitAdapter.java (diff)
Commit 1635eeba33368aee52f23baebcfd74c25a7f113a by Sven Gothel
JOGLNewtAppletBase: Typo of new PNG icons .. used AE's 'gray' instead of BE's 'grey', which is used for the filename

Same as 42d3b31d1becd8eb8e2847c87e14e47e15e730cd
The file was modifiedsrc/newt/classes/com/jogamp/newt/awt/applet/JOGLNewtAppletBase.java (diff)
Commit 9dcaf86ad6ae08e60c68abd4c069f3ab19807854 by Sven Gothel
JAWTWindow.JAWTComponentListener: Minor Cleanup
The file was modifiedsrc/nativewindow/classes/com/jogamp/nativewindow/awt/JAWTWindow.java (diff)
Commit 367b704b448b4ebabcfc62cc29e61fa5760514d1 by Sven Gothel
OSXMisc CALayer::FixCALayerLayout: Fix visible:=false case, i.e. don'r override cached visibleOpacity w/ forced zero when called twice
The file was modifiedsrc/nativewindow/native/macosx/OSXmisc.m (diff)