SuccessChanges

Summary

  1. Bug 1189: Fix gcc redefinition error, even thought typedef equals - on (details)
  2. Bug 1249 - NEWT X11: setVisible(false) IconicState not listening to (details)
Commit 56eb5025694064ad3e25cf2fb7ba0cabbda8ee67 by Sven Gothel
Bug 1189: Fix gcc redefinition error, even thought typedef equals - on
OpenIndiana w/ old'ish gcc
The file was modifiedmake/stub_includes/opengl/GLES2/gl2ext-supplement.h (diff)
Commit dca5d36370ec5eb44998bae593880e3b10cc9a4e by Sven Gothel
Bug 1249 - NEWT X11: setVisible(false) IconicState not listening to
_NET_WM_STATE_HIDDEN; setVisible(true) not restoring from
_NET_WM_STATE_HIDDEN
Using Gnome Shell 3.14.4-1~deb8u1 disclosed an issue w/ our newly
utilized IconicState/_NET_WM_STATE_HIDDEN, i.e. visibleChanged(false)
was never received.
This is a regression of commit 2d837a7a7130702ad36b694875613fae77c7ef06,
which utilizes WM_CHANGE_STATE_IDX + IconicState for visibility on
top-level windows.
This bug consist out of _two_ isssue:
1) setVisible(false) IconicState not listening to _NET_WM_STATE_HIDDEN
Here, we 'listen' to _NET_WM_STATE_HIDDEN when receiving
ConfigureNotify
if supported _and_ XMapWindow has been issued.
In such case existence/non-existence of _NET_WM_STATE_HIDDEN determines
visibility.
Otherwise, we have wait for MapNotify/UnmapNotify.
  The 'XMapWindow has been issued' criteria is tracked by new field
'JavaWindow.isMapped'
and set/cleared when we actually issue XMapWindow/XUnmapWindow!
2) setVisible(true) not restoring from _NET_WM_STATE_HIDDEN
It has been observed that restoring IconicState/_NET_WM_STATE_HIDDEN
via XMapWindow or even NormalState may not work reliably on WMs.
See
<https://stackoverflow.com/questions/30192347/how-to-restore-a-window-with-xlib>
  Hence we restore from this WM state via NormalState _and_
_NET_ACTIVE_WINDOW.
Both strategies seem to work well on KDE as well as on Gnome.
The file was modifiedsrc/newt/native/X11Common.h (diff)
The file was modifiedsrc/newt/native/X11Display.c (diff)
The file was modifiedsrc/newt/classes/jogamp/newt/WindowImpl.java (diff)
The file was modifiedsrc/newt/native/X11Window.c (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/newt/parenting/TestParenting01NEWT.java (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/newt/TestGLWindows00NEWT.java (diff)
The file was modifiedsrc/newt/native/WindowsWindow.c (diff)
The file was modifiedsrc/test/com/jogamp/opengl/test/junit/newt/TestGLWindows01NEWT.java (diff)
The file was modifiedmake/scripts/tests.sh (diff)