Bug 1283

Summary:	Jogl can't find #include shader relative files
Product:	[JogAmp] Jogl	Reporter:	Giuseppe Barbieri <elect86>
Component:	opengl	Assignee:	Giuseppe Barbieri <elect86>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gouessej, sgothel
Priority:	P4
Version:	2.4.0
Hardware:	pc_x86_64
OS:	windows
Type:	DEFECT	SCM Refs:	jogl 7e4c32ba709346ce4009d50e506ebc4c079d7c1e jogl 2319a207873cf88da4ce0dadc5e7a2e5479d4254
Workaround:	---

Description Giuseppe Barbieri 2016-01-12 11:01:11 CET

Minimal sample to replicate the bug

https://github.com/elect86/joglBug

Comment 1 Giuseppe Barbieri 2016-01-29 13:53:43 CET

I just found out that this work

#include draw-image-space-rendering.glsl

May we modify it in order to accept also the quotes?

#include "draw-image-space-rendering.glsl"

Comment 2 Julien Gouesse 2016-02-16 20:03:18 CET

(In reply to Giuseppe Barbieri from comment #1)
> I just found out that this work
> 
> #include draw-image-space-rendering.glsl
> 
> May we modify it in order to accept also the quotes?
> 
> #include "draw-image-space-rendering.glsl"

Are you sure that JOGL is to blame for that?

Comment 3 Giuseppe Barbieri 2016-02-16 21:18:04 CET

yeah, I created a pull request

https://github.com/sgothel/jogl/pull/95

Comment 4 Giuseppe Barbieri 2016-02-16 21:21:19 CET

btw, I just saw there are other pull requests lying there

Comment 5 Julien Gouesse 2016-02-17 00:19:58 CET

(In reply to Giuseppe Barbieri from comment #4)
> btw, I just saw there are other pull requests lying there

Some of them have been accepted but not through Github.

Comment 6 Giuseppe Barbieri 2016-02-17 08:26:12 CET

through what then?

Comment 7 Julien Gouesse 2016-02-29 17:38:30 CET

(In reply to Giuseppe Barbieri from comment #6)
> through what then?

Sven can receive git patches by email without using Github.

In my humble opinion, we should remove the quotes only when they are at the start and at the end of the string.

Comment 8 Giuseppe Barbieri 2016-02-29 17:43:49 CET

I agree, shall I modify the pull then?

Comment 9 Julien Gouesse 2016-02-29 20:36:14 CET

(In reply to Giuseppe Barbieri from comment #8)
> I agree, shall I modify the pull then?

There is no hurry and you'll have to make a pull request against my repository later when I'm ready anyway.

Comment 10 Julien Gouesse 2017-06-06 10:55:06 CEST

I accepted Guiseppe's pull request but I have to edit a few things (braces, ...).

Comment 11 Sven Gothel 2019-03-26 23:20:59 CET

Bug 1283: Remove shader include filename quotes if exists at start and end only