Minimal sample to replicate the bug https://github.com/elect86/joglBug
I just found out that this work #include draw-image-space-rendering.glsl May we modify it in order to accept also the quotes? #include "draw-image-space-rendering.glsl"
(In reply to Giuseppe Barbieri from comment #1) > I just found out that this work > > #include draw-image-space-rendering.glsl > > May we modify it in order to accept also the quotes? > > #include "draw-image-space-rendering.glsl" Are you sure that JOGL is to blame for that?
yeah, I created a pull request https://github.com/sgothel/jogl/pull/95
btw, I just saw there are other pull requests lying there
(In reply to Giuseppe Barbieri from comment #4) > btw, I just saw there are other pull requests lying there Some of them have been accepted but not through Github.
through what then?
(In reply to Giuseppe Barbieri from comment #6) > through what then? Sven can receive git patches by email without using Github. In my humble opinion, we should remove the quotes only when they are at the start and at the end of the string.
I agree, shall I modify the pull then?
(In reply to Giuseppe Barbieri from comment #8) > I agree, shall I modify the pull then? There is no hurry and you'll have to make a pull request against my repository later when I'm ready anyway.
I accepted Guiseppe's pull request but I have to edit a few things (braces, ...).
Bug 1283: Remove shader include filename quotes if exists at start and end only