| Summary: | whitespace key events are classified as 'non printable' | ||
|---|---|---|---|
| Product: | [JogAmp] Newt | Reporter: | mike <msiggy> |
| Component: | awt | Assignee: | Sven Gothel <sgothel> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | --- | ||
| Version: | 1 | ||
| Hardware: | pc_x86_64 | ||
| OS: | windows | ||
| Type: | --- | SCM Refs: |
4c34f5980bddcdc84b10cb3bcbb96b365b9d471e
4e6c2aadd7d652db3ba1f35eef1a3d61d6e692d0
|
| Workaround: | --- | ||
|
Description
mike
2013-06-27 00:28:59 CEST
(In reply to comment #0) > KeyEvents fired by whitespace keys such as tab, enter, and backspace are > flagged as 'non printable'. In other words they return 'true' for their > 'isPrintableKey()' method. .. they do not return 'true' for their 'isPrintableKey()' method, but should! ENTER (currently wrong keyCode 0xa -> 0xd) is not a printable IMHO but more a control sequence. TAB + BS .. well, adding them is a compromise maybe, while understanding the view from a 'editor' perspective not font-definition perspective. TAB + BS are considered 'printable' - Compromise of 'editor' view and 'font-definition' view. ENTER not. Fix ENTER code: 0xa -> 0xd ! Revise commit 4c34f5980bddcdc84b10cb3bcbb96b365b9d471e (Bug 767): TAB, BS and CR/ENTER are printable for NEWT KeyEvent and font handling. Fix regression. - Original behavior was treating CR/ENTER them as printable, lets keep it this way. - KeyEvent: Query these 3 whitespaces upfront, no need to incl. them in 'nonPrintableKeys'. - Fix regression: Native VK_ENTER was not change in commit 4c34f5980bddcdc84b10cb3bcbb96b365b9d471e. .. TL;DR .. so it is as you (Mike) suggested. All good! |