Bug 767 - whitespace key events are classified as 'non printable'
Summary: whitespace key events are classified as 'non printable'
Status: RESOLVED FIXED
Alias: None
Product: Newt
Classification: JogAmp
Component: awt (show other bugs)
Version: 1
Hardware: pc_x86_64 windows
: --- minor
Assignee: Sven Gothel
URL:
Depends on:
Blocks:
 
Reported: 2013-06-27 00:28 CEST by mike
Modified: 2013-07-03 23:08 CEST (History)
0 users

See Also:
Type: ---
SCM Refs:
4c34f5980bddcdc84b10cb3bcbb96b365b9d471e 4e6c2aadd7d652db3ba1f35eef1a3d61d6e692d0
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mike 2013-06-27 00:28:59 CEST 
KeyEvents fired by whitespace keys such as tab, enter, and backspace are flagged as 'non printable'. In other words they return 'true' for their 'isPrintableKey()' method.
Comment 1 Sven Gothel 2013-07-02 16:13:20 CEST 
(In reply to comment #0)
> KeyEvents fired by whitespace keys such as tab, enter, and backspace are
> flagged as 'non printable'. In other words they return 'true' for their
> 'isPrintableKey()' method.

.. they do not return 'true' for their  'isPrintableKey()' method, but should!
Comment 2 Sven Gothel 2013-07-02 18:48:48 CEST 
ENTER (currently wrong keyCode 0xa -> 0xd)
is not a printable IMHO but more a control sequence.

TAB + BS .. well, adding them is a compromise maybe,
while understanding the view from a 'editor' perspective
not font-definition perspective.
Comment 3 Sven Gothel 2013-07-02 19:02:10 CEST 
TAB + BS are considered 'printable' - Compromise of 'editor' view and 'font-definition' view. ENTER not. Fix ENTER code: 0xa -> 0xd !
Comment 4 Sven Gothel 2013-07-03 23:08:28 CEST 
Revise commit 4c34f5980bddcdc84b10cb3bcbb96b365b9d471e (Bug 767): 
TAB, BS and CR/ENTER are printable for NEWT KeyEvent and font handling. Fix regression.
    
  - Original behavior was treating CR/ENTER them as printable, lets keep it this way.
  - KeyEvent: Query these 3 whitespaces upfront, no need to incl. them in 'nonPrintableKeys'.
    
  - Fix regression: Native VK_ENTER was not change 
    in commit 4c34f5980bddcdc84b10cb3bcbb96b365b9d471e.

.. TL;DR .. so it is as you (Mike) suggested. All good!