Bug 1000 - wrong argument order
Summary: wrong argument order
Status: RESOLVED FIXED
Alias: None
Product: Jocl
Classification: JogAmp
Component: opencl (show other bugs)
Version: 1
Hardware: All all
: --- normal
Assignee: Wade Walker
URL:
Depends on:
Blocks:
 
Reported: 2014-03-14 13:06 CET by liuhui2005
Modified: 2014-04-07 22:19 CEST (History)
2 users (show)

See Also:
Type: ---
SCM Refs:
65144f3de56b4fc47262399d0b3bcb0fa5f3feee
Workaround: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description liuhui2005 2014-03-14 13:06:53 CET
JOCL class CLCommandQueue Line 413

putCopyBufferRect(  src, dest, srcOriginX, srcOriginY, 0,
                            destOriginX, destOriginY, 0,
                            rangeX, rangeY, 1,
                            srcRowPitch, srcSlicePitch, destSlicePitch, destRowPitch, condition, events);


destSlicePitch and  destRowPitch should be switched to match its method declaration: 

 public CLCommandQueue putCopyBufferRect(CLBuffer<?> src, CLBuffer<?> dest,
            int srcOriginX, int srcOriginY, int srcOriginZ, int destOriginX, int destOriginY, int destOriginZ, int rangeX, int rangeY, int rangeZ,
            long srcRowPitch, long srcSlicePitch, long destRowPitch, long destSlicePitch,
            CLEventList condition, CLEventList events) {
Comment 1 Wade Walker 2014-04-04 22:42:24 CEST
I'll look at this once I check in some pending commits for other bugs.
Comment 2 Wade Walker 2014-04-07 22:19:33 CEST
Committed this to master just now. It might take a little while to appear in the nightly builds, since the build server is down temporarily.

Good catch! Thanks for reporting this.