Bug 1466 - Graph / GraphUI: Fix color mixing in Region shader with texture, colorStatic and colorChannel
Summary: Graph / GraphUI: Fix color mixing in Region shader with texture, colorStatic ...
Status: RESOLVED FIXED
Alias: None
Product: Jogl
Classification: JogAmp
Component: graph (show other bugs)
Version: 2.6.0
Hardware: All all
: P4 normal
Assignee: Sven Gothel
URL:
Depends on:
Blocks:
 
Reported: 2023-09-30 01:15 CEST by Sven Gothel
Modified: 2023-09-30 01:49 CEST (History)
2 users (show)

See Also:
Type: DEFECT
SCM Refs:
297c48f4fefd1ab59800524ea5f0dd56684d6786
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Gothel 2023-09-30 01:15:39 CEST 
Current color mix: texture * color_channel * color_static
is useless in GraphUI.

color_static shall modulate the texture, which works.
But in case of color_channel (attribute/varying)
we want it to be mixed so it can become the more dominant color
for e.g. a border.

Desired is:

color = vec4( mix( tex.rgb * gcu_ColorStatic.rgb, gcv_Color.rgb, gcv_Color.a ), 
              mix( tex.a * gcu_ColorStatic.a, 1, gcv_Color.a) );
Comment 1 Sven Gothel 2023-09-30 01:49:40 CEST 
See commit 297c48f4fefd1ab59800524ea5f0dd56684d6786