Bug 688 - Removal of NEWT KeyEvent.EVENT_KEY_TYPED and KeyListener.keyTyped(KeyEvent)
Summary: Removal of NEWT KeyEvent.EVENT_KEY_TYPED and KeyListener.keyTyped(KeyEvent)
Status: RESOLVED FIXED
Alias: None
Product: Newt
Classification: JogAmp
Component: core (show other bugs)
Version: 1
Hardware: All all
: P3 enhancement
Assignee: Sven Gothel
URL:
Depends on: 678
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-11 10:34 CET by Sven Gothel
Modified: 2013-06-17 10:12 CEST (History)
2 users (show)

See Also:
Type: ---
SCM Refs:
jogl 85338858f5c58694fa88e77df1386d0556887944 jogl 8b33170ec6fd3f215976875cb66d746fa1b48f61 jogl bdfb74818aa224bd96a15f232f417e921e0d8f63
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Gothel 2013-02-11 10:34:54 CET 
I reviewed the NEWT key press/release/type thingy again (windows, etc ..).
While solving the UTF-char problem (again), I see that the TYPED event is
redundant now, since we deliver the UTF-char for all events.

Hence I like to remova NEWT KeyEvent.EVENT_KEY_TYPED and
it's KeyListener.keyTyped(KeyEvent) listener.

This will reduce the event 1/3 for keyboard .. which is reasonable IMHO
considering the 'headaches' of the change.

User code change: Simply trigger on RELEASE instead of TYPED.

Opinions ?

~Sven
Comment 1 Sven Gothel 2013-02-19 08:07:00 CET 
http://jogamp.org/git/?p=jogl.git;a=commit;h=85338858f5c58694fa88e77df1386d0556887944

- prepared, marked deprecated .. etc see commit message
- code change also shows redundancy of TYPED event
Comment 2 Xerxes Rånby 2013-03-05 08:52:36 CET 
TODO: This bugs needs to be fixed for the Rasberry Pi LinuxEventDeviceTracker, that still use the depricated code, to make the generated events compatible with new client code such as the new JMonkeyEngine that already have been patched for this bug.
http://forum.jogamp.org/JOGL-2-0-OpenGL-OpenGL-ES-backend-for-LibGDX-tp4027689p4028486.html
Comment 3 Xerxes Rånby 2013-03-05 11:41:55 CET 
> TODO: This bugs needs to be fixed for the Rasberry Pi
> LinuxEventDeviceTracker, that still use the depricated code, to make the
> generated events compatible with new client code such as the new
> JMonkeyEngine that already have been patched for this bug.
> http://forum.jogamp.org/JOGL-2-0-OpenGL-OpenGL-ES-backend-for-LibGDX-
> tp4027689p4028486.html

Kudos to sgothel for already implementing the TODO in 85338858f5c58694fa88e77df1386d0556887944
http://jogamp.org/git/?p=jogl.git;a=blobdiff;f=src/newt/classes/jogamp/newt/driver/linux/LinuxEventDeviceTracker.java;h=2c0e6d3dd5163b80b21de9e5fac15f8d499245cc;hp=5efce2524a9ac343d2a9e2c7ac4bab826252a149;hb=85338858f5c58694fa88e77df1386d0556887944;hpb=a40ee817a3bd537b0de7018772b0835f995a1bed
Comment 4 Sven Gothel 2013-06-17 10:12:07 CEST 
gone .. done