Bug 839 - Clarify GLStateTracker enabled/disabled state, obfuscated by 83d3a3f2ea8dc328e621b3abbe671f46379c7e65
Summary: Clarify GLStateTracker enabled/disabled state, obfuscated by 83d3a3f2ea8dc328...
Status: RESOLVED FIXED
Alias: None
Product: Jogl
Classification: JogAmp
Component: core (show other bugs)
Version: 2
Hardware: All all
: --- enhancement
Assignee: Sven Gothel
URL:
Depends on:
Blocks:
 
Reported: 2013-09-20 11:35 CEST by Sven Gothel
Modified: 2013-09-21 05:19 CEST (History)
1 user (show)

See Also:
Type: ---
SCM Refs:
4ef07dc20a3d867feb1c51b4ce22ae3d06094781
Workaround: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Gothel 2013-09-20 11:35:53 CEST 
- 83d3a3f2ea8dc328e621b3abbe671f46379c7e65
    - GLStateTracker.clearStates(boolean enable) was only supposed to be used
      for GLContext.destroy()!
      Now it's called in GLContext.resetStates(),
      which disables GLStateTracker always!

- cf95674e16d34a85191d3af0a35d1357e011fcac
    - GLStateTracker.clearStates() -> GLStateTracker.clearStates(boolean enable)
      Changed to disable state tracker at GLContext.destroy().
Comment 1 Sven Gothel 2013-09-21 05:17:22 CEST 
(In reply to comment #0)
> - 83d3a3f2ea8dc328e621b3abbe671f46379c7e65
>     - GLStateTracker.clearStates(boolean enable) was only supposed to be used
>       for GLContext.destroy()!
>       Now it's called in GLContext.resetStates(),
>       which disables GLStateTracker always!

The GLStateTracker was not disabled w/ 1st resetStates() call,
since the fields were not yet initialized.

Shall clarify this situation, i.e. remove code obfuscation.

> 
> - cf95674e16d34a85191d3af0a35d1357e011fcac
>     - GLStateTracker.clearStates() -> GLStateTracker.clearStates(boolean
> enable)
>       Changed to disable state tracker at GLContext.destroy().