Bug 921 - Logging should be used instead of system out/err calls
Summary: Logging should be used instead of system out/err calls
Status: UNCONFIRMED
Alias: None
Product: General
Classification: JogAmp
Component: source_code (show other bugs)
Version: unspecified
Hardware: All all
: P5 enhancement
Assignee: Sven Gothel
URL:
Depends on:
Blocks:
 
Reported: 2013-12-08 19:11 CET by Brahim Djoudi
Modified: 2015-09-27 03:14 CEST (History)
0 users

See Also:
Type: FEATURE
SCM Refs:
21d6cfafdc088e75981d710c672a668fddfdf298
Workaround: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brahim Djoudi 2013-12-08 19:11:46 CET
A logging framework (SLF4J or Java Logging) should be used to log messages.
Applications using JOGAMP libraries would produce consistent messages by means of a unique controllable logging framework.
Comment 1 Sven Gothel 2013-12-11 01:54:01 CET
(In reply to comment #0)
> A logging framework (SLF4J or Java Logging) should be used to log messages.
> Applications using JOGAMP libraries would produce consistent messages by
> means of a unique controllable logging framework.

If you like to do so .. you may go ahead.
However, no extra [external] dependency shall be created
_and_ the costs [performance/footprint] shall be minimal.

This is a biggy .. w/ questionable results IMHO,
since we only enable this logging for DEBUG cases.
You may also consider that native DEBUG code also uses stderr.

Current State: All DEBUG code uses the stderr channel ..
Comment 2 Brahim Djoudi 2013-12-12 21:46:38 CET
Hi Sven

Thank you for the advice.
I agree with you: the processing of the entire library to replace all stderr debug output is a significant task. Only the most important messages should be logged. First, I only need to disable debug outputs produced by default.
This weekend, I intend to browse the code of the JOGL library (included in my project) to have a better idea of the required work.
Comment 3 Sven Gothel 2013-12-18 22:27:59 CET
(In reply to comment #2)
> First, I only need to disable debug outputs produced by default.

There should be none, ofc.

But if those still exist, it's an orthogonal issue, i.e. shall be fixed
by adding the typical 'if(DEBUG) { }' while still using stderr.
Comment 4 Brahim Djoudi 2013-12-18 22:52:16 CET
(In reply to comment #3)
> (In reply to comment #2)

I got errors from the class FPSAnimator.
Comment 5 Sven Gothel 2014-01-22 20:31:53 CET
21d6cfafdc088e75981d710c672a668fddfdf298
  FPSAnimator debug output on stderr shall happen only if DEBUG is enabled