Skip to content
The Jenkins Controller is preparing for shutdown. No new builds can be started.
Success

Changes

Summary

  1. gluegen: generics annotations for various ArrayList/List use (details)
  2. gluegen: remove two fast-path tests that can never trigger (details)
  3. gluegen: replace Thread name with name of lock file in (details)
  4. Buffers: Add normalized put methods, i.e. incl. value range conversion; (details)
  5. Minor revert of clone replacement w/ copt-ctor of commit (details)
  6. Fix Buffers.copy<Type>Buffer[asByteBuffer](..): Reset position of the (details)
  7. Revert "Minor revert of clone replacement w/ copt-ctor of commit (details)
Commit d7fb6a7bcfbd2d5ac452abdcdd31fb4d71441c70 by Harvey Harrison
gluegen: generics annotations for various ArrayList/List use

- Use the copy constructor rather than ArrayList.clone()
- constrain listsEqual  so the compiler will warn about comparing lists of different types

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/EnumType.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/FunctionType.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/CompoundType.java (diff)
The file was modifiedsrc/java/com/jogamp/common/util/IntIntHashMap.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/Type.java (diff)
Commit 28410cfb398b510b4f748f3a1134dd13dae9f7c4 by Harvey Harrison
gluegen: remove two fast-path tests that can never trigger

ignores and unimplemented are both Set<Pattern>, they cannot contain a String,
immediately after these 'fast paths' we loop over the patterns calling .matches()
which makes sense, so remove the misleading tests.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
The file was modifiedsrc/java/com/jogamp/gluegen/JavaConfiguration.java (diff)
Commit 4309d1334a2b036c7bf15612199bb7391a57980b by Harvey Harrison
gluegen: replace Thread name with name of lock file in SingletonInstanceFileLock error message

The getName() call here is currently calling Thread.getName() inherited by the
anonymous inner class.  This is ambiguous, and likely meant to call the getName()
method of SingletonInstanceFileLock, which would output the lockfile name.

In any event, infoPrefix() is already adding the Thread name for us.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
The file was modifiedsrc/java/jogamp/common/util/locks/SingletonInstanceFileLock.java (diff)
Commit cae1502304faac54fb6673ed31eb1493e8388497 by Sven Gothel
Buffers: Add normalized put methods, i.e. incl. value range conversion; New util. ValueConv for primitive type value conversion
The file was modifiedmake/scripts/runtest.sh (diff)
The file was addedsrc/java/com/jogamp/common/util/ValueConv.java (diff)
The file was modifiedsrc/java/com/jogamp/common/nio/Buffers.java (diff)
The file was addedsrc/junit/com/jogamp/common/util/TestValueConversion.java (diff)
Commit 73e8828566404e864170688dfb4fd530a83f8add by Sven Gothel
Minor revert of clone replacement w/ copt-ctor of commit d7fb6a7bcfbd2d5ac452abdcdd31fb4d71441c70

clone of ArrayList is more shallow than it's clone operation (?)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/CompoundType.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/FunctionType.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/EnumType.java (diff)
Commit febd5421a3e00673bd43cecd19aaa088eafb99e7 by Sven Gothel
Fix Buffers.copy<Type>Buffer[asByteBuffer](..): Reset position of the passed buffer (was missing).

This is an API regression as introduced in commit 25cc744f6bd5ca97e0ae58fa7e1c35f7b0f3046d
where JOGL's BufferUtil and GlueGen's were merged and API doc elaborated.
The latter states the desired fact that the source passed buffer's position shall remain
unchanged, however no code was added to take care of this detail.
The file was modifiedsrc/java/com/jogamp/common/nio/Buffers.java (diff)
Commit 761b2855b9c01c421ecd4d435a828a67b3a2471b by Sven Gothel
Revert "Minor revert of clone replacement w/ copt-ctor of commit d7fb6a7bcfbd2d5ac452abdcdd31fb4d71441c70"

This reverts commit 73e8828566404e864170688dfb4fd530a83f8add.

Convinced after discussing semantics w/ Harvey Harrison:

"the copy-constructor is way for predictable (as in branch-predictable)
and has better cache behavior, it can issue almost all the writes in
parallel, and has no exception catching.

So, the copy-constructor actually ends up being more efficient, and
you get typechecking to boot."
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/CompoundType.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/EnumType.java (diff)
The file was modifiedsrc/java/com/jogamp/gluegen/cgram/types/FunctionType.java (diff)