Skip to content
The Jenkins Controller is preparing for shutdown. No new builds can be started.
Unstable

Changes

Summary

  1. gluegen: use explicit ArrayList constructor to avoid @SuppressWarnings (details)
  2. gluegen: use enhanced for-loops in ArrayHashSet (details)
Commit d70f55e63c38331486249bdfdbd1234ce4bbeb09 by Harvey Harrison
gluegen: use explicit ArrayList constructor to avoid @SuppressWarnings and clone()

ArrayList.clone does _not_ make a shallow copy, a new internal array is allocated.
As such, there is nearly no benefit to using clone().

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
The file was modified src/java/com/jogamp/common/util/ArrayHashSet.java (diff)
Commit d721e4f356d2cb272b0eb47829220a5b2b23c2dc by Harvey Harrison
gluegen: use enhanced for-loops in ArrayHashSet

Fixes an infinite loop in addAll due to the following line:
mod = mod || add(iter.next()) ;

After the first successful add, mod will be true and thereafter iter.next
will never be called again, due to || shortcutting.  the loop will then run forever
as any further elements will never be taken from the iterator, so hasNext will always
be true.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
The file was modified src/java/com/jogamp/common/util/ArrayHashSet.java (diff)