Changes

gluegen: trim trailing whitespace from GlueGenTask

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: small cleanup and type annotation in GlueGenTask

- remove an unused import
- annotate includesList with type information
- small code cleanup now that the type information is present

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: remove trailing whitespace from cgrammer Type class

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: fix equals comparison in cgrammer Type class

name was being compared to itself, rather than the name of the type we are comparing,
looks like a simple typo.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: break apart a complex conditional in Type.equals() for readability

- move the cheap integer compares earlier before the String comparisons

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: remove trailing whitespace from psuedo-C parser

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: simplify expression comparing against Boolean.TRUE

As a last resort we can just return the boolean value directly here, also no
need to try/catch as valueOf does not throw any exceptions.

Pointed out by Findbugs.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

gluegen: conditional cleanup in Type.equals()

- instanceof includes null checking
- simplify comparison of name, either they are the same object (possibly null)
or they compare equal as strings

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Intermediate revised Type.java edit before reducing

Reducing Type's equals

ProcAddressEmitter: Remove 'guessing' argument names from types, since they are ambiguous - better use default generic ones to avoid confusion.